Skip to content

feat: raise Errors::UnknownView for missing render view#589

Open
SAY-5 wants to merge 1 commit into
procore-oss:mainfrom
SAY-5:feat-missing-view-error
Open

feat: raise Errors::UnknownView for missing render view#589
SAY-5 wants to merge 1 commit into
procore-oss:mainfrom
SAY-5:feat-missing-view-error

Conversation

@SAY-5

@SAY-5 SAY-5 commented May 19, 2026

Copy link
Copy Markdown

Adds Blueprinter::Errors::UnknownView, raised by Rendering#hashify when the requested view does not exist. It inherits from BlueprinterError so existing rescue blocks keep working, and lets callers distinguish a 400 (caller-supplied bad view name) from a 500 (any other BlueprinterError). This ports the V2 class forward as suggested in #569.

Closes #569

Checklist:

  • I have updated the necessary documentation
  • I have signed off all my commits as required by DCO
  • My build is green

@SAY-5 SAY-5 requested review from a team and ritikesh as code owners May 19, 2026 21:53
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
@SAY-5 SAY-5 force-pushed the feat-missing-view-error branch from f5fe1c4 to f847800 Compare June 26, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Raise a specific error class for missing view

2 participants