Attachment upload with file dialog by alanpoon · Pull Request #674 · project-robius/robrix

alanpoon · 2026-01-26T13:38:42Z

Screen.Recording.2026-01-26.at.4.09.11.PM.mov

macOS
Android
Linux
Windows

kevinaboos · 2026-01-27T08:01:22Z

awesome!

I know this isn't yet complete, but I wanted to quickly drop in and suggest using rfd instead of makepad's internal file API. rfd is the de facto crate for this kind of thing, and I plan to shortly create a robius crate that wraps rfd, so we'll end up with a similar API.

Plus, with rfd you'd get immediate support for all 3 desktop platforms.

alanpoon · 2026-01-28T13:10:50Z

awesome!

I know this isn't yet complete, but I wanted to quickly drop in and suggest using rfd instead of makepad's internal file API. rfd is the de facto crate for this kind of thing, and I plan to shortly create a robius crate that wraps rfd, so we'll end up with a similar API.

Plus, with rfd you'd get immediate support for all 3 desktop platforms.

Kindly refer to this implementation of the rfd. https://github.com/Vjze/YY_DPS/blob/edb15ffc85b646c27547081b30a0e6f0d8ba688b/src/export/export_view.rs#L158 This requires the tokio runtime in a field in export screen

kevinaboos · 2026-01-28T17:48:50Z

awesome!
I know this isn't yet complete, but I wanted to quickly drop in and suggest using rfd instead of makepad's internal file API. rfd is the de facto crate for this kind of thing, and I plan to shortly create a robius crate that wraps rfd, so we'll end up with a similar API.
Plus, with rfd you'd get immediate support for all 3 desktop platforms.

Kindly refer to this implementation of the rfd. https://github.com/Vjze/YY_DPS/blob/edb15ffc85b646c27547081b30a0e6f0d8ba688b/src/export/export_view.rs#L158 This requires the tokio runtime in a field in export screen

Ok, what's the issue with that? Is that problematic? Apologies, but I'm not quite sure what point you're trying to make.

Moly has used rfd in their app, works fine AFAIK.

alanpoon · 2026-01-30T16:19:32Z

awesome!
I know this isn't yet complete, but I wanted to quickly drop in and suggest using rfd instead of makepad's internal file API. rfd is the de facto crate for this kind of thing, and I plan to shortly create a robius crate that wraps rfd, so we'll end up with a similar API.
Plus, with rfd you'd get immediate support for all 3 desktop platforms.

Kindly refer to this implementation of the rfd. https://github.com/Vjze/YY_DPS/blob/edb15ffc85b646c27547081b30a0e6f0d8ba688b/src/export/export_view.rs#L158 This requires the tokio runtime in a field in export screen

Ok, what's the issue with that? Is that problematic? Apologies, but I'm not quite sure what point you're trying to make.

Moly has used rfd in their app, works fine AFAIK.

Thanks for referring me to Moly. File Dialog does not work well in asynchronously in macOS as file dialog is only allowing in main thread.

src/sliding_sync.rs

src/shared/progress_bar.rs

src/sliding_sync.rs

src/shared/file_previewer.rs

src/app.rs

kevinaboos

Thanks Alan, looks very good — impressive work here!

I left comments about a few major structural decisions, but it's mostly just about refactoring things into more modular widgets. I also left some questions about using higher-level Timeline APIs vs Room APIs for sending attachments.

src/room/room_input_bar.rs

kevinaboos · 2026-02-05T03:10:40Z

macOS

Android

Linux

Windows

Also, now that you're using rfd, can you confirm whether this also works for Linux and Windows? Theoretically they are also included as supported platforms in rfd.

…o image_upload

kevinaboos

Looks pretty good, just a few minor comments.

src/home/upload_progress.rs

src/room/room_input_bar.rs

src/shared/file_upload_modal.rs

src/room/room_input_bar.rs

src/sliding_sync.rs

Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>

kevinaboos

Thanks for the fixes.

I see that you ran an auto-formatter on the code, which makes it impossible for me to review the key changes that you actually made. Take a look at the room_input_bar diff, for example, and you'll see just how many unnecessary changes were made.

A friendly reminder to not run tools like rustfmt on whole files because it destroys our existing custom formatting decisions. Please undo all unnecessary formatting-only changes across all changed files (most of which are not an improvement, particularly in the room_input_bar.rs file), and then manually inspect your own PR's diff to ensure that there are no superfluous changes. Then, after that, please re-request a review from me.

src/home/upload_progress.rs

kevinaboos · 2026-03-21T20:16:20Z

I've just merged the migration to Makepad 2.0. For this PR, kindly stick with Makepad 1.0 and fully address my comments here, and then once we have agreed, then we can start the migration to 2.0. I'm happy to help as well, if there are any parts of 2.0 that you're unsure of.

kevinaboos

Thanks, everything looks good! Just one small comment, and then you can proceed with the migration to Makepad 2.0.

kevinaboos · 2026-03-24T18:47:46Z

src/home/upload_progress.rs

+            {
+                log!("Retrying upload");
+                // Hide retry button
+                self.button(ids!(retry_button)).set_visible(cx, false);


nit: instead of hiding buttons, which is typically a bad user experience, it's better to just disable them. (And don't forget to re-enable them when needed).

That also avoids the problem of the UI jumping around/moving unexpectedly.

alanpoon added 7 commits January 23, 2026 21:46

add image upload

72020cb

added progress bar widget

824b6cf

file upload modal

ba038cc

added file_previewer

51e388c

code improvement

172462b

fix clippy

13109ff

add FilePreviewer in App

bdb0b34

alanpoon self-assigned this Jan 26, 2026

alanpoon added 2 commits January 30, 2026 15:54

image upload improvement

0ca00fb

Merge branch 'main' into image_upload

2afea24

alanpoon added the waiting-on-review This issue is waiting to be reviewed label Jan 30, 2026

alanpoon marked this pull request as ready for review January 30, 2026 16:18

image_upload improvement

f922cf2

alanpoon force-pushed the image_upload branch from eae0bfa to f922cf2 Compare January 31, 2026 01:38

fix clippy

59860ab

kevinaboos reviewed Feb 5, 2026

View reviewed changes

kevinaboos requested changes Feb 5, 2026

View reviewed changes

kevinaboos removed the waiting-on-review This issue is waiting to be reviewed label Feb 5, 2026

kevinaboos assigned kevinaboos and alanpoon and unassigned alanpoon Feb 5, 2026

kevinaboos added the waiting-on-author This issue is waiting on the original author for a response label Feb 5, 2026

alanpoon added 3 commits February 5, 2026 11:55

Merge branch 'main' into image_upload

cc335f7

send attachment improvement

36b2432

fix file upload modal white space issue

e41250c

Merge branch 'image_upload' of https://github.com/alanpoon/robrix int…

65acc69

…o image_upload

alanpoon added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Feb 25, 2026

kevinaboos requested changes Feb 25, 2026

View reviewed changes

kevinaboos added waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-review This issue is waiting to be reviewed labels Feb 25, 2026

alanpoon and others added 8 commits February 26, 2026 08:25

Avoid string allocations

3338a8b

Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>

remove string allocation

98d230e

Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>

PopupItem Fix

295ea3d

Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>

fix format

e1007c6

Add retry button

c85e246

Merge branch 'main' into image_upload

b702d7e

fix clippy

b3bc48f

fix formatting

c874b5a

alanpoon added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Feb 26, 2026

Fix clippy

7f7f08b

kevinaboos requested changes Mar 14, 2026

View reviewed changes

src/home/upload_progress.rs Outdated Show resolved Hide resolved

kevinaboos added waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-review This issue is waiting to be reviewed labels Mar 14, 2026

alanpoon added 4 commits March 23, 2026 17:54

revert formatting for room_input_bar

f3b76f4

add UploadViewState enum

db65190

minor code improvement

56ade94

code optimization

c13111d

alanpoon removed the waiting-on-author This issue is waiting on the original author for a response label Mar 23, 2026

alanpoon mentioned this pull request Mar 24, 2026

Attachment upload with file dialog Project-Robius-China/robrix2#7

Open

kevinaboos requested changes Mar 24, 2026

View reviewed changes

change from set_visible to set_enable

7a86e85

alanpoon mentioned this pull request Mar 26, 2026

Attachment upload #784

Open

Conversation

alanpoon commented Jan 26, 2026

Uh oh!

kevinaboos commented Jan 27, 2026

Uh oh!

alanpoon commented Jan 28, 2026

Uh oh!

kevinaboos commented Jan 28, 2026

Uh oh!

alanpoon commented Jan 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevinaboos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevinaboos commented Feb 5, 2026

Uh oh!

kevinaboos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevinaboos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kevinaboos commented Mar 21, 2026

Uh oh!

kevinaboos left a comment

Choose a reason for hiding this comment

Uh oh!

kevinaboos Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants