Experiment DO NOT MERGE move webhook config type into webhook package #4972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeier
force-pushed
the
experiment2
branch
2 times, most recently
from
4a65ff8 to
180f85a
Compare
SoloJacobs
reviewed
Feb 10, 2026
| @@ -0,0 +1,108 @@ | |||
| // Copyright The Prometheus Authors | |||
Contributor
Contributor
Author
There was a problem hiding this comment.
Well if you want to use receiver functions of the notifier-config types I would advise to keep everything in one place. Maybe we can set a side a 5-10 timebox on Friday to talk about this experiment.
This is an experiment to evaluate a route how notifier specific code could be better spearated. Signed-off-by: Christoph Maser <christoph.maser+github@gmail.com>
TheMeier
force-pushed
the
experiment2
branch
from
180f85a to
ea2ae19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to evaluate a route how notifier specific code could be better spearated.