Skip to content

Comments

ci(release-please): fix footer not appearing on release PRs#1902

Merged
zeitlinger merged 1 commit intomainfrom
fix/release-please-footer-workaround
Feb 20, 2026
Merged

ci(release-please): fix footer not appearing on release PRs#1902
zeitlinger merged 1 commit intomainfrom
fix/release-please-footer-workaround

Conversation

@zeitlinger
Copy link
Member

Summary

  • pull-request-footer was not being applied to release PRs because
    release-please defaults separatePullRequests to true for
    single-package configs, which skips the Merge plugin responsible for
    applying the footer
  • Setting separate-pull-requests: false forces the Merge plugin to run

Context

  • This is a workaround for an upstream bug in release-please where
    pull-request-footer is silently ignored for single-package repos
  • Affects both regular release PRs and Java SNAPSHOT PRs
  • Same issue exists in grafana/flint and likely any single-package repo
    using pull-request-footer

Test plan

Release-please defaults `separatePullRequests` to `true` for
single-package configs, which skips the Merge plugin that applies
the configured `pull-request-footer`. Setting `separate-pull-requests`
to `false` explicitly forces the Merge plugin to run.

See: https://github.com/googleapis/release-please/issues (upstream bug)
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger
Copy link
Member Author

Upstream fix: googleapis/release-please#2685

zeitlinger added a commit to grafana/flint that referenced this pull request Feb 20, 2026
## Summary
- `pull-request-footer` was not being applied to release PRs because
  release-please defaults `separatePullRequests` to `true` for
  single-package configs, which skips the Merge plugin responsible for
  applying the footer
- Setting `separate-pull-requests: false` forces the Merge plugin to run

## Context
- Same workaround applied to prometheus/client_java in
  prometheus/client_java#1902

## Test plan
- [ ] After merging, verify the next release PR includes the footer

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger merged commit a483539 into main Feb 20, 2026
10 checks passed
@zeitlinger zeitlinger deleted the fix/release-please-footer-workaround branch February 20, 2026 17:11
@zeitlinger
Copy link
Member Author

Tracking removal of this workaround: #1903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant