Add clear() method to CollectorRegistry#1154
Open
veeceey wants to merge 1 commit intoprometheus:masterfrom
Open
Add clear() method to CollectorRegistry#1154veeceey wants to merge 1 commit intoprometheus:masterfrom
veeceey wants to merge 1 commit intoprometheus:masterfrom
Conversation
This commit adds a clear() method to CollectorRegistry that removes all collectors from the registry at once, reducing boilerplate when clearing registries. Fixes prometheus#1141 Signed-off-by: Varun Chawla <varun_6april@hotmail.com>
d9e3278 to
b00ed3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
clear()method toCollectorRegistrythat removes all collectors from the registry at once. This reduces boilerplate when clearing registries, as users no longer need to manually unregister each collector individually.Changes
clear()method toCollectorRegistryclass inprometheus_client/registry.pytest_clear_works()to verify the method works correctlyUsage Example
Before:
After:
Test Plan
clear()removes all collectorsFixes #1141