Update rules_rust to 1.69.0, rust to 1.93.1.#496
Update rules_rust to 1.69.0, rust to 1.93.1.#496leonm1 wants to merge 6 commits intoproxy-wasm:mainfrom
Conversation
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
leonm1
requested review from
PiotrSikora,
martijneken and
mpwarres
as code owners
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
You need to regenerate crates (use bazelisk run //bazel/cargo/wasmsign:crates_vendor without arguments to avoid updating dependencies, since that's going to pollute PR).
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
| EXPECT_TRUE(host->isErrorLogged(" - std::panicking::begin_panic")); | ||
| // Check for the function name 'one' in the backtrace, which may appear with or without | ||
| EXPECT_TRUE(host->isErrorLogged(" - std::panicking")); | ||
| // Check for the function name 'two' in the backtrace, which may appear with or without |
There was a problem hiding this comment.
The code below still loook for function one not two as in the updated (outdated?) comment.
| // Proxy-Wasm only prints up to 9 stack frames in V8. | ||
| // Ensure that we can see the `one` frame in the stack trace for assertions by inlining two and | ||
| // three. |
There was a problem hiding this comment.
This test doesn't seem to be broken on main, so where does this new "9 stack frames" limit come from? Is the panic stacktrace so much longer in plugins built with recent Rust?
There was a problem hiding this comment.
FYI, this is what I get from local testing after reverting your changes in this file:
[ RUN ] WasmEngines/TestVm.Trap/v8
TRACE from integration: [host->vm] trigger()
ERROR from integration: Function: trigger failed: Uncaught RuntimeError: unreachable
Proxy-Wasm plugin in-VM backtrace:
0: 0x1792 - _RNvCsdBezzDwma51_7___rustc12___rust_abort
1: 0x1ea - _RNvCsdBezzDwma51_7___rustc18___rust_start_panic
2: 0x1f8 - _RNvCsdBezzDwma51_7___rustc10rust_panic
3: 0x27ec - std::panicking::panic_with_hook::h51c5edeeb48e69d3
4: 0x2568 - std::panicking::begin_panic::_$u7b$$u7b$closure$u7d$$u7d$::he40991d1daf020e4
5: 0x252d - std::sys::backtrace::__rust_end_short_backtrace::haadd8ba7ebd902fa
6: 0x26d4 - std::panicking::begin_panic::h3650af640422e449
7: 0x186 - _wasm_trap_wasm::three::h2cc0537245992bde
8: 0x16e - _wasm_trap_wasm::two::h8d62b9963e06f5ba
9: 0x164 - _wasm_trap_wasm::one::h027a3f589f2f611c
[ OK ] WasmEngines/TestVm.Trap/v8 (114 ms)
So there indeed seems to be limit on the number of stack frames, since it doesn't show the trigger function, but there are 10 frames, not 9.
There was a problem hiding this comment.
In any case, #499 might be a better approach than massaging tests to pass.
| // Proxy-Wasm only prints up to 9 stack frames in V8. | ||
| // Ensure that we can see the `one` frame in the stack trace for assertions by inlining two and | ||
| // three. |
There was a problem hiding this comment.
FYI, this is what I get from local testing after reverting your changes in this file:
[ RUN ] WasmEngines/TestVm.Trap/v8
TRACE from integration: [host->vm] trigger()
ERROR from integration: Function: trigger failed: Uncaught RuntimeError: unreachable
Proxy-Wasm plugin in-VM backtrace:
0: 0x1792 - _RNvCsdBezzDwma51_7___rustc12___rust_abort
1: 0x1ea - _RNvCsdBezzDwma51_7___rustc18___rust_start_panic
2: 0x1f8 - _RNvCsdBezzDwma51_7___rustc10rust_panic
3: 0x27ec - std::panicking::panic_with_hook::h51c5edeeb48e69d3
4: 0x2568 - std::panicking::begin_panic::_$u7b$$u7b$closure$u7d$$u7d$::he40991d1daf020e4
5: 0x252d - std::sys::backtrace::__rust_end_short_backtrace::haadd8ba7ebd902fa
6: 0x26d4 - std::panicking::begin_panic::h3650af640422e449
7: 0x186 - _wasm_trap_wasm::three::h2cc0537245992bde
8: 0x16e - _wasm_trap_wasm::two::h8d62b9963e06f5ba
9: 0x164 - _wasm_trap_wasm::one::h027a3f589f2f611c
[ OK ] WasmEngines/TestVm.Trap/v8 (114 ms)
So there indeed seems to be limit on the number of stack frames, since it doesn't show the trigger function, but there are 10 frames, not 9.
| if (engine_ == "v8") { | ||
| EXPECT_TRUE(host->isErrorLogged("Proxy-Wasm plugin in-VM backtrace:")); | ||
| EXPECT_TRUE(host->isErrorLogged(" - std::panicking::begin_panic")); | ||
| EXPECT_TRUE(host->isErrorLogged(" - std::panicking")); |
There was a problem hiding this comment.
I'm fine with those, but for the record, those changes are not necessary, since the std::panicking::begin_panic is still in the backtrace.
PiotrSikora
changed the title
2 participants
No description provided.