Test enhancement

.travis.yml

@@ -0,0 +1,13 @@
+language: php
+
+php:
+  - 7.0
+  - 7.1
+  - 7.2
+  - 5.6
+
+before_script:
+  - composer install --no-interaction
+
+script:
+  - php vendor/bin/phpunit

composer.json

@@ -10,13 +10,19 @@
         }
     ],
     "require": {
+        "php": ">=5.6"
     },
     "require-dev": {
-        "phpunit/phpunit": "4.1.4"
+        "phpunit/phpunit": "^4.8 || ^5.7 || ^6.5"
     },
     "autoload": {
         "psr-4": {
             "Psecio\\Validation\\": "src/"
         }
+    },
+    "autoload-dev": {
+        "psr-4": {
+            "Psecio\\Validation\\": "tests/"
+        }
     }
 }

phpunit.xml

@@ -12,4 +12,9 @@
             <directory>./tests</directory>
         </testsuite>
     </testsuites>
+    <filter>
+        <whitelist>
+            <directory suffix=".php">src</directory>
+        </whitelist>
+    </filter>
 </phpunit>

tests/Check/AfterTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class AfterTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class AfterTest extends TestCase
 {
     protected $after;
 

tests/Check/AlphaTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class AlphaTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class AlphaTest extends TestCase
 {
     protected $alpha;
 

tests/Check/AlphanumTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class AlphanumTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class AlphanumTest extends TestCase
 {
     protected $alphanum;
 

tests/Check/Before.php → tests/Check/BeforeTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class BeforeTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class BeforeTest extends TestCase
 {
     protected $before;
 
@@ -20,8 +22,8 @@ public function testCheckValidAfterDate()
         $start = '+2 days';
         $end = 'yesterday';
 
-        $this->after->setAdditional(['start' => $start]);
-        $this->assertTrue($this->after->execute($end));
+        $this->before->setAdditional(['start' => $start]);
+        $this->assertTrue($this->before->execute($end));
     }
 
 }

tests/Check/BooleanTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class BooleanTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class BooleanTest extends TestCase
 {
     protected $boolean;
 

tests/Check/DateTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class DateTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class DateTest extends TestCase
 {
     protected $date;
 

tests/Check/EmailTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class EmailTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class EmailTest extends TestCase
 {
     protected $email;
 

tests/Check/InTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class InTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class InTest extends TestCase
 {
     protected $in;
 

tests/Check/IntegerTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class IntegerTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class IntegerTest extends TestCase
 {
     protected $int;
 

tests/Check/IpTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class IpTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class IpTest extends TestCase
 {
     protected $ip;
 

tests/Check/IsarrayTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class IsarrayTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class IsarrayTest extends TestCase
 {
     protected $array;
 

tests/Check/JsonTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class JsonTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class JsonTest extends TestCase
 {
     protected $json;
 

tests/Check/LengthTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class LengthTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class LengthTest extends TestCase
 {
     protected $length;
 

tests/Check/NumericTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class NumericTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class NumericTest extends TestCase
 {
     protected $num;
 

tests/Check/RegexTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class RegexTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class RegexTest extends TestCase
 {
     protected $regex;
 

tests/Check/RequiredTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation\Check;
 
-class RequiredTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class RequiredTest extends TestCase
 {
     protected $req;
 

tests/CheckSetTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation;
 
-class CheckSetTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class CheckSetTest extends TestCase
 {
     /**
      * Test the looping of the set via a foreach
@@ -39,4 +41,19 @@ public function testArrayAccessValid()
         unset($set[2]);
         $this->assertFalse(isset($set[2]));
     }
+
+    /**
+     * Test that the check set can remove the specific index
+     */
+    public function testRemove()
+    {
+        $checks = [
+            new \Psecio\Validation\Check\Integer('test1'),
+            new \Psecio\Validation\Check\Numeric('test2')
+        ];
+        $set = new CheckSet($checks);
+        $set->remove(0);
+
+        $this->assertFalse(isset($set[0]));
+    }
 }

tests/CheckTest.php

@@ -2,7 +2,9 @@
 
 namespace Psecio\Validation;
 
-class CheckTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class CheckTest extends TestCase
 {
     /**
      * Test setting the additional info on construct
@@ -53,4 +55,54 @@ public function testGetAdditionalByNameInvalid()
         $check = $this->getMockForAbstractClass('\Psecio\Validation\Check', [$addl]);
         $this->assertNull($check->get('wrongkey'));
     }
+
+    /**
+     * Test that can get the input
+     */
+    public function testGetInput()
+    {
+        $addl = [
+            'foo' => 'bar'
+        ];
+        $check = $this->getMockForAbstractClass('\Psecio\Validation\Check', [$addl]);
+        $check->setInput('input_value');
+        $this->assertEquals('input_value', $check->getInput());
+    }
+
+    /**
+     * Test that can get the key
+     */
+    public function testGetKey()
+    {
+        $addl = [
+            'foo' => 'bar'
+        ];
+        $check = $this->getMockForAbstractClass('\Psecio\Validation\Check', [$addl]);
+        $check->setKey('key');
+        $this->assertEquals('key', $check->getKey());
+    }
+
+    /**
+     * Test that can get the type
+     */
+    public function testGetType()
+    {
+        $addl = [
+            'foo' => 'bar'
+        ];
+        $check = $this->getMockForAbstractClass('\Psecio\Validation\Check', [$addl]);
+        $this->assertStringStartsWith('mock_', $check->getType());
+    }
+
+    /**
+     * Test that can get the message if name is null
+     */
+    public function testGetMessage()
+    {
+        $addl = [
+            'foo' => 'bar'
+        ];
+        $check = $this->getMockForAbstractClass('\Psecio\Validation\Check', [$addl]);
+        $this->assertEquals('', $check->getMessage());
+    }
 }

tests/RuleTest.php

@@ -1,9 +1,10 @@
 <?php
 
 namespace Psecio\Validation;
-use Psecio\Validation\CheckSet;
 
-class RuleTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class RuleTest extends TestCase
 {
     protected $rule;
 
@@ -110,4 +111,30 @@ public function testParseCheckMappingValid()
         $this->assertEquals(1, count($result));
         $this->assertInstanceOf('\Psecio\Validation\Check\Isarray', $result[0]);
     }
+
+    public function testGetMessages()
+    {
+        $checks = 'array';
+        $result = $this->rule->parse($checks);
+
+        $this->assertEquals([], $this->rule->getMessages());
+    }
+
+    public function testGetMessage()
+    {
+        $checks = 'array';
+        $result = $this->rule->parse($checks);
+        $this->rule->setMessages(['message']);
+
+        $this->assertEquals('message', $this->rule->getMessage(0));
+        $this->assertNull($this->rule->getMessage(1));
+    }
+
+    public function testGetFailures()
+    {
+        $checks = 'array';
+        $result = $this->rule->parse($checks);
+
+        $this->assertEquals([], $this->rule->getFailures(true));
+    }
 }