Skip to content

Invalidate cached responses after POST #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcelmaatkamp wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Invalidate cached responses after POST #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cachecontrol/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@


class CacheControlAdapter(HTTPAdapter):
invalidating_methods = {"PUT", "PATCH", "DELETE"}
invalidating_methods = {"POST", "PUT", "PATCH", "DELETE"}

def __init__(
self,
Expand Down
5 changes: 5 additions & 0 deletions tests/test_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ def test_delete_invalidates_cache(self, url, sess):
sess.get(url)
assert not r2.from_cache

def test_post_invalidates_cache(self, url, sess):
sess.get(url)
sess.post(url, data={"foo": "bar"})
assert not sess.get(url).from_cache

def test_close(self):
cache = mock.Mock(spec=DictCache)
sess = Session()
Expand Down