Skip to content

[Improvement] Letting the developer initialize subscriber_key, publish_key and uuid for PNConfiguration during initialization #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JanluOfficial wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Improvement] Letting the developer initialize subscriber_key, publish_key and uuid for PNConfiguration during initialization #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pubnub/pnconfiguration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,19 @@ class PNConfiguration(object):
DEFAULT_CRYPTO_MODULE = LegacyCryptoModule
_locked = False

def __init__(self):
def __init__(self,
subscriber_key: str | None = None,
publish_key: str | None = None,
uuid: str | None = None):
# TODO: add validation
self._uuid = None
self._uuid = uuid
self.origin = "ps.pndsn.com"
self.ssl = True
self.non_subscribe_request_timeout = 10
self.subscribe_request_timeout = 310
self.connect_timeout = 10
self.subscribe_key = None
self.publish_key = None
self.subscribe_key = subscriber_key
self.publish_key = publish_key
self.secret_key = None
self.cipher_key = None
self._cipher_mode = AES.MODE_CBC
Expand Down