[WIP] Fix concurrency consistency for internals_pp_manager under multiple-interpreters
#5947
+61
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
changed the title
internals_pp_manager under multiple-interpretersinternals_pp_manager under multiple-interpreters
…rpreters-concurrency
…ith the same class names.
The pre_init needs to check if it is in a subinterpreter or not. But in 3.13+ this static initializer runs in the main interpreter. So we need to check this later, during the exec phase.
…was where it was... Should not hurt anything to do it extra times here.
The count was not used, it was just checked for > 1, we now accomplish this by setting the flag.
rwgk
reviewed
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up for:
gil_safe_call_once_and_store#5933See discussion:
gil_safe_call_once_and_store#5933 (comment)gil_safe_call_once_and_store#5933 (comment)gil_safe_call_once_and_store#5933 (comment)gil_safe_call_once_and_store#5933 (comment)Suggested changelog entry:
internals_pp_managerunder multiple-interpreters