fix X509Extension __str__() method for unknow extension types#1239
Open
fix X509Extension __str__() method for unknow extension types#1239
Conversation
fbce364 to
2f5b78d
Compare
Author
|
tests seem to be failing due to #1240 |
2f5b78d to
0fe4a4a
Compare
Author
|
tests are now failing due to an issue in a new release of sphinx (7.2.5) sphinx-doc/sphinx#11662 |
0fe4a4a to
a037ec9
Compare
Member
|
Thanks @ich199! The change generally makes sense to me. Would you mind adding a |
Author
|
Thanks @mhils, I've created the binding in cryptography as requested and that's been merged. I'm guessing it would be preferred to backport that to |
Member
|
Awesome, thanks! Bumping the cryptography requirement here is perfectly fine (and preferred), cryptography and pyOpenSSL releases go more or less in tandem. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1238
fixes: #270
Unsure if it would be preferred to use
65536instead of1 << 16when definingX509V3_EXT_ERROR_UNKNOWN, but I copied the syntax used in OpenSSL