Fix mailoutbox fixture initialization with database-dependent fixtures - #1309
Open
gh640 wants to merge 1 commit into
Open
Fix mailoutbox fixture initialization with database-dependent fixtures#1309gh640 wants to merge 1 commit into
mailoutbox fixture initialization with database-dependent fixtures#1309gh640 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #589
Ensure database setup completes before
mailoutboxcaptures Django'smail.outboxto preventmailoutboxfrom retaining a stale list when Django'sTestCase._pre_setup()(that is invoked in_django_db_helperfixture) replacesmail.outbox.This PR intentionally covers only database dependencies that are visible in pytest's fixture graph. It does not cover fixtures that dynamically request database access after
mailoutboxhas been initialized, for example:Supporting that case would require a more invasive approach, such as preserving and synchronizing the existing outbox around
_django_db_helperand Django's_pre_setup(). I am happy to change to the broader approach if maintainers prefer it.