Handle :: in loadscope parametrized ids#1350
Open
itscloud0 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #1335.
LoadScopeScheduling._split_scope()currently takes the last::in the nodeid without accounting for parametrized ids. Values like::1orcafe:cafe::cafemake--dist=loadscopesplit a single module into multiple work units, so related tests can be scattered across workers and pay repeated fixture setup costs.Solution
Track the last top-level
::outside parametrization brackets when deriving the loadscope key.This keeps the existing class-vs-module grouping behavior, while ignoring
::that only appear inside parametrized ids. I also added:--dist=loadscopeVerification
python -m pytest testing/test_loadscope.py -qpython -m pytest testing/acceptance_test.py -q -k 'test_by_module or test_by_class or test_by_module_with_double_colons_in_parametrize_ids'python -m ruff check src/xdist/scheduler/loadscope.py testing/acceptance_test.py testing/test_loadscope.pyLimitations
This only changes
loadscopescope parsing.loadfileandloadgroupbehavior is unchanged.