[PR #14475/984cabfa backport][9.0.x] fix mark expression scanner: search for backslash in string value, not entire input#14478
Merged
bluetech merged 1 commit intoMay 14, 2026
Conversation
…not entire input (#14475) The backslash check in the string literal lexer was searching the entire input expression (input.find("\")) instead of only the current string value (value.find("\")). This caused false rejections when an identifier containing a backslash appeared in the same expression as a string literal. For example, `pytest -k 'test\nfoo\n and mark(x="y")'` would fail with "escaping not supported" even though the backslash is in the identifier, not the string. Closes #14474 (cherry picked from commit 984cabf)
bluetech
approved these changes
May 14, 2026
bluetech
deleted the
patchback/backports/9.0.x/984cabfaccf8aa69fe49097ed3d07bd60d05f240/pr-14475
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #14475 as merged into main (984cabf).
The backslash check in the string literal lexer was searching the entire input expression (input.find("\")) instead of only the current string value (value.find("\")). This caused false rejections when an identifier containing a backslash appeared in the same expression as a string literal.
For example, pytest -k 'test\nfoo\n and mark(x="y")' would fail with "escaping not supported" even though the backslash is in the identifier, not the string.
The fix:
Added a regression test for the case where backslashes in identifiers coexist with string literals in the same expression.
Closes #14474