gh-143995: Eliminate redundant refcounting in the JIT from LOAD_ATTR_MODULE #143996
+57
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aisk
requested review from
Fidget-Spinner,
ericsnowcurrently,
markshannon,
savannahostrowski and
tomasr8
as code owners
Objects/moduleobject.c
Outdated
Comment on lines
1129
to
1135
| void | ||
| _PyModule_ExactDealloc(PyObject *self) | ||
| { | ||
| assert(PyModule_CheckExact(self)); | ||
| module_dealloc(self); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
No need to do this. The main benefit of CLOSE_SPECIALIZED is to tell the bytecodes generator the call is non-escaping. In this case, this is actually escaping as deallocating a module object frees other data.
Python/bytecodes.c
Outdated
| macro(LOAD_ATTR_MODULE) = | ||
| unused/1 + | ||
| _LOAD_ATTR_MODULE + | ||
| _POP_TOP_MODULE + |
Python/optimizer_bytecodes.c
Outdated
Comment on lines
640
to
645
| op(_POP_TOP_MODULE, (value --)) { | ||
| if (PyJitRef_IsBorrowed(value) || | ||
| sym_is_immortal(PyJitRef_Unwrap(value))) { | ||
| REPLACE_OP(this_instr, _POP_TOP_NOP, 0, 0); | ||
| } | ||
| } |
| } | ||
|
|
||
| op(_LOAD_ATTR_MODULE, (dict_version/2, index/1, owner -- attr)) { | ||
| op(_LOAD_ATTR_MODULE, (dict_version/2, index/1, owner -- attr, o)) { |
Member
There was a problem hiding this comment.
Tests are failing because the case where this is promoted to globals successfully now has wrong stack effect. It should use the SHUFFLE/INSERT opcodes rather than LOAD_CONST_INLINE_BORROW.
If you'd like to look into it, let me know, otherwise I can fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated `uops` before:
Generated `uops` after:
Diff:
The time cost for 1000000 iterations in the
testfuncin the test case is reduced from approximately 126 seconds to 120 seconds.LOAD_ATTR_MODULE#143995