Skip to content

gh-144130: support getrandom syscall on non-linux #144131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dankm wants to merge 8 commits into
base: main
Choose a base branch
from
+8 −4
Open

gh-144130: support getrandom syscall on non-linux #144131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
47afea8
support getrandom syscall on non-linux
dankm Feb 20, 2024
f3af163
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 22, 2026
7df1eb7
posixmodule: Be more specific in include comment.
dankm Jan 23, 2026
a3d4868
bootstrap_hash: add note about GRND_NONBLOCK on the BSDs
dankm Jan 23, 2026
b203399
Update Modules/posixmodule.c
dankm Jan 23, 2026
c333508
Merge branch 'main' into dankm/getrandom
dankm Jan 27, 2026
6d10c3b
Make the header include order match the bootstrap one
dankm Jan 23, 2026
a40fd75
Merge branch 'main' into dankm/getrandom
dankm Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2026-01-22-15-54-57.gh-issue-144130.QaHIxE.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add support for FreeBSD's implementation of getrandom, so :func:`os.getrandom` works there too.
5 changes: 4 additions & 1 deletion Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,11 @@
#ifdef HAVE_LINUX_RANDOM_H
# include <linux/random.h> // GRND_RANDOM
#endif
#if defined(HAVE_SYS_RANDOM_H) && (defined(HAVE_GETRANDOM) || defined(HAVE_GETENTROPY))
Copy link
Member

@serhiy-storchaka serhiy-storchaka Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code below does not use getentropy(), so it should be removed.

# include <sys/random.h> // getrandom(), GRND_NONBLOCK on FreeBSD and NetBSD
#endif
#ifdef HAVE_GETRANDOM_SYSCALL
Copy link
Member

@serhiy-storchaka serhiy-storchaka Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#ifdef HAVE_GETRANDOM_SYSCALL
#if !defined(HAVE_GETRANDOM) && defined(HAVE_GETRANDOM_SYSCALL)

Also, in the code below which checks HAVE_GETRANDOM_SYSCALL, we should also check HAVE_GETRANDOM and use getrandom() if available.

Copy link
Member

@vstinner vstinner Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to leave the PR as it is (#ifdef HAVE_GETRANDOM_SYSCALL). I will write a following PR to reuse Python/bootstrap_hash.c code in Modules/posixmodule.c. The bootstrap_hash.c code is more complete, it handles properly Solaris for example.

# include <sys/syscall.h> // syscall()
# include <sys/syscall.h> // SYS_getrandom
#endif

#ifdef HAVE_POSIX_SPAWN
Expand Down
2 changes: 1 addition & 1 deletion Python/bootstrap_hash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# include <linux/random.h> // GRND_NONBLOCK
# endif
# if defined(HAVE_SYS_RANDOM_H) && (defined(HAVE_GETRANDOM) || defined(HAVE_GETENTROPY))
# include <sys/random.h> // getrandom()
# include <sys/random.h> // getrandom(), GRND_NONBLOCK on FreeBSD and NetBSD
# endif
# if !defined(HAVE_GETRANDOM) && defined(HAVE_GETRANDOM_SYSCALL)
# include <sys/syscall.h> // SYS_getrandom
Expand Down
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7439,7 +7439,7 @@ AC_LINK_IFELSE(
#include <stddef.h>
#include <unistd.h>
#include <sys/syscall.h>
#include <linux/random.h>
#include <sys/random.h>

int main(void) {
char buffer[1];
Expand Down
Loading