gh-74902: Avoid hitting unicode.org for test data #144195
Merged
+23
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use our own pythontest.net instead.
Member
Author
|
unicode.org returned 403s to a couple of my buildbot workers; using pythontest.net instead ensures that we're not taxing their server and puts the source of our test data in our control. Test data added to pythontest.net in python/pythontestdotnet@a66b3bb |
serhiy-storchaka
approved these changes
Jan 23, 2026
| f"into the test data directory") | ||
| except (OSError, HTTPException) as exc: | ||
| self.skipTest(f"Failed to download {TESTDATAURL}: {exc}") | ||
| TESTDATAFILE = "GraphemeBreakTest.txt" |
Member
There was a problem hiding this comment.
So, it is not in auxiliary?
Member
Author
There was a problem hiding this comment.
It is not; since we only have three files in there (up from two before adding this one), the extra directory seemed unnecessary. Easy enough to add back if you want it, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use our own pythontest.net instead.