gh-144220: Copy metadata before files in shutil.copytree()#145869
Closed
vstinner wants to merge 1 commit intopython:mainfrom
Closed
gh-144220: Copy metadata before files in shutil.copytree()#145869vstinner wants to merge 1 commit intopython:mainfrom
vstinner wants to merge 1 commit intopython:mainfrom
Conversation
shutil.copytree() now copies directory metadata before copying files. It prevents an error when setting an extended attribute (bcachefs.casefold) on an non-empty directory.
Member
Author
|
This PR changes Without this change, the |
Member
Author
|
This change doesn't work if the source directory has the Example on FreeBSD 15: |
Member
Author
|
My PR changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shutil.copytree() now copies directory metadata before copying files. It prevents an error when setting an extended attribute (bcachefs.casefold) on an non-empty directory.
shutil.copytreefails on bcachefs case insensitive directories #144220