[librt] Move librt submodule files to dedicated subdirectories #20629
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move librt_internal.[ch] into mypyc/lib-rt/internal/ and librt_base64.[ch] into mypyc/lib-rt/base64/ to better reflect that these files implement separate librt submodules. Updated all references to point to the new locations: - mypyc/codegen/emitmodule.py: updated include paths - mypyc/build.py: updated source file paths - mypyc/lib-rt/setup.py: updated source file paths - mypy/cache.py: updated comment with new path Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
p-sawicki
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now all .c and .h files for
librt.base64live undermypyc/lib-rt/base64, for example.This makes the structure easier to follow, since now the files for each submodule are in a dedicated directory. I'm planning to add some additional submodules soon, some of which have multiple files, so I think it makes sense to restructure now.
The extra ops files are still in the top-level
mypyc/lib-rtdirectory, since they are linked to mypyc-compiled libraries instead oflibrtproper. We can revisit this later; I'm not sure what's the best approach.I did this with claude code.