Skip to content

Add pydata.it domain zone to global infrastructure#4561

Merged
marcoacierno merged 1 commit intomainfrom
pydata-it-domain
Feb 6, 2026
Merged

Add pydata.it domain zone to global infrastructure#4561
marcoacierno merged 1 commit intomainfrom
pydata-it-domain

Conversation

@patrick91
Copy link
Member

What

ToDo

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Ready Ready Preview Feb 6, 2026 9:58am

@claude
Copy link
Contributor

claude bot commented Feb 6, 2026

This PR adds a new Route53 zone for the pydata.it domain. The structure follows the existing pattern used for other domain modules (pycon_it, python_it, pyconit_dev).

Issues:

  1. Missing nameserver outputs (infrastructure/global/domains/pydata_it/): Other domain zones like python_it would typically have outputs or documentation for nameservers needed to complete domain delegation. Without exporting the nameservers, there's no easy way for the domain registrar to be updated with the correct AWS Route53 nameservers.

  2. Hardcoded TTL value (infrastructure/global/domains/pydata_it/records.tf:6): The TXT record uses a TTL of 60 seconds, which is unusually low for a verification record. This creates unnecessary DNS query load. Consider using a more standard TTL (e.g., 3600) unless there's a specific reason for such frequent updates.

  3. Incomplete PR description: The PR body has empty "What" and "ToDo" sections. Add context about why pydata.it is being added and what remaining work (if any) needs to happen after this infrastructure is deployed.

@marcoacierno marcoacierno merged commit 27359ae into main Feb 6, 2026
8 checks passed
@marcoacierno marcoacierno deleted the pydata-it-domain branch February 6, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants