You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds a new Route53 zone for the pydata.it domain. The structure follows the existing pattern used for other domain modules (pycon_it, python_it, pyconit_dev).
Issues:
Missing nameserver outputs (infrastructure/global/domains/pydata_it/): Other domain zones like python_it would typically have outputs or documentation for nameservers needed to complete domain delegation. Without exporting the nameservers, there's no easy way for the domain registrar to be updated with the correct AWS Route53 nameservers.
Hardcoded TTL value (infrastructure/global/domains/pydata_it/records.tf:6): The TXT record uses a TTL of 60 seconds, which is unusually low for a verification record. This creates unnecessary DNS query load. Consider using a more standard TTL (e.g., 3600) unless there's a specific reason for such frequent updates.
Incomplete PR description: The PR body has empty "What" and "ToDo" sections. Add context about why pydata.it is being added and what remaining work (if any) needs to happen after this infrastructure is deployed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ToDo