Open
Conversation
Merged
fbarchard
reviewed
Mar 30, 2024
Collaborator
fbarchard
left a comment
fbarchard
left a comment
There was a problem hiding this comment.
I'm not an expert in the OS layer. The code looks okay. Is it necessary to have freebsd instead of linux?
Author
|
Hi Marat, This is an updated pull request that works fine on FreeBSD. Could you please merge it? Thanks, |
|
Hello, Any news on that PR ? FYI, I used it to update our pcsx2 port and it works fine here. Cheers, Ganael. |
fbarchard
reviewed
Jun 2, 2024
| goto cleanup; | ||
| } | ||
| packages = | ||
| calloc(freebsd_topology.packages, sizeof(struct cpuinfo_package)); |
Collaborator
There was a problem hiding this comment.
Is packages the reason you're wanting a branch from linux?
The latest linux kernel on android and riscv requires packages support so it would be best to use common code to avoid freebsd diverging in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #172, updated to the latest cpuinfo revision.