Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Jan 5, 2026

Stack from ghstack (oldest at bottom):

Add non-owning constructor to MaybeOwningStorage that allows wrapping
external memory without taking ownership. This is needed for from_blob()
which creates tensors from user-provided data pointers.

Changes:

  • Add MaybeOwningStorage(device, data, nbytes) non-owning constructor
  • Add is_owning() method to query ownership mode
  • Non-owning storage uses no-op deleter so external memory is not freed

Differential Revision: D89943727

Add non-owning constructor to MaybeOwningStorage that allows wrapping
external memory without taking ownership. This is needed for from_blob()
which creates tensors from user-provided data pointers.

Changes:
- Add MaybeOwningStorage(device, data, nbytes) non-owning constructor
- Add is_owning() method to query ownership mode
- Non-owning storage uses no-op deleter so external memory is not freed

Differential Revision: [D89943727](https://our.internmc.facebook.com/intern/diff/D89943727/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16441

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 7676b63 with merge base 4f8dbde (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2026
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This was referenced Jan 5, 2026
…rnal memory"

Add non-owning constructor to MaybeOwningStorage that allows wrapping
external memory without taking ownership. This is needed for from_blob()
which creates tensors from user-provided data pointers.

Changes:
- Add MaybeOwningStorage(device, data, nbytes) non-owning constructor
- Add is_owning() method to query ownership mode
- Non-owning storage uses no-op deleter so external memory is not freed

Differential Revision: [D89943727](https://our.internmc.facebook.com/intern/diff/D89943727/)

[ghstack-poisoned]
…rnal memory"

Add non-owning constructor to MaybeOwningStorage that allows wrapping
external memory without taking ownership. This is needed for from_blob()
which creates tensors from user-provided data pointers.

Changes:
- Add MaybeOwningStorage(device, data, nbytes) non-owning constructor
- Add is_owning() method to query ownership mode
- Non-owning storage uses no-op deleter so external memory is not freed

Differential Revision: [D89943727](https://our.internmc.facebook.com/intern/diff/D89943727/)

[ghstack-poisoned]
…rnal memory"

Add non-owning constructor to MaybeOwningStorage that allows wrapping
external memory without taking ownership. This is needed for from_blob()
which creates tensors from user-provided data pointers.

Changes:
- Add MaybeOwningStorage(device, data, nbytes) non-owning constructor
- Add is_owning() method to query ownership mode
- Non-owning storage uses no-op deleter so external memory is not freed

Differential Revision: [D89943727](https://our.internmc.facebook.com/intern/diff/D89943727/)

[ghstack-poisoned]
…rnal memory"

Add non-owning constructor to MaybeOwningStorage that allows wrapping
external memory without taking ownership. This is needed for from_blob()
which creates tensors from user-provided data pointers.

Changes:
- Add MaybeOwningStorage(device, data, nbytes) non-owning constructor
- Add is_owning() method to query ownership mode
- Non-owning storage uses no-op deleter so external memory is not freed

Differential Revision: [D89943727](https://our.internmc.facebook.com/intern/diff/D89943727/)

[ghstack-poisoned]
@meta-codesync meta-codesync bot merged commit 2985cc5 into gh/gasoonjia/83/base Jan 21, 2026
164 of 168 checks passed
@meta-codesync meta-codesync bot deleted the gh/gasoonjia/83/head branch January 21, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants