-
Notifications
You must be signed in to change notification settings - Fork 806
[slimtensor] Add non-owning storage mode for wrapping external memory #16441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add non-owning constructor to MaybeOwningStorage that allows wrapping external memory without taking ownership. This is needed for from_blob() which creates tensors from user-provided data pointers. Changes: - Add MaybeOwningStorage(device, data, nbytes) non-owning constructor - Add is_owning() method to query ownership mode - Non-owning storage uses no-op deleter so external memory is not freed Differential Revision: [D89943727](https://our.internmc.facebook.com/intern/diff/D89943727/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16441
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 7676b63 with merge base 4f8dbde ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
…rnal memory" Add non-owning constructor to MaybeOwningStorage that allows wrapping external memory without taking ownership. This is needed for from_blob() which creates tensors from user-provided data pointers. Changes: - Add MaybeOwningStorage(device, data, nbytes) non-owning constructor - Add is_owning() method to query ownership mode - Non-owning storage uses no-op deleter so external memory is not freed Differential Revision: [D89943727](https://our.internmc.facebook.com/intern/diff/D89943727/) [ghstack-poisoned]
…rnal memory" Add non-owning constructor to MaybeOwningStorage that allows wrapping external memory without taking ownership. This is needed for from_blob() which creates tensors from user-provided data pointers. Changes: - Add MaybeOwningStorage(device, data, nbytes) non-owning constructor - Add is_owning() method to query ownership mode - Non-owning storage uses no-op deleter so external memory is not freed Differential Revision: [D89943727](https://our.internmc.facebook.com/intern/diff/D89943727/) [ghstack-poisoned]
…rnal memory" Add non-owning constructor to MaybeOwningStorage that allows wrapping external memory without taking ownership. This is needed for from_blob() which creates tensors from user-provided data pointers. Changes: - Add MaybeOwningStorage(device, data, nbytes) non-owning constructor - Add is_owning() method to query ownership mode - Non-owning storage uses no-op deleter so external memory is not freed Differential Revision: [D89943727](https://our.internmc.facebook.com/intern/diff/D89943727/) [ghstack-poisoned]
…rnal memory" Add non-owning constructor to MaybeOwningStorage that allows wrapping external memory without taking ownership. This is needed for from_blob() which creates tensors from user-provided data pointers. Changes: - Add MaybeOwningStorage(device, data, nbytes) non-owning constructor - Add is_owning() method to query ownership mode - Non-owning storage uses no-op deleter so external memory is not freed Differential Revision: [D89943727](https://our.internmc.facebook.com/intern/diff/D89943727/) [ghstack-poisoned]
2985cc5
into
gh/gasoonjia/83/base
Stack from ghstack (oldest at bottom):
Add non-owning constructor to MaybeOwningStorage that allows wrapping
external memory without taking ownership. This is needed for from_blob()
which creates tensors from user-provided data pointers.
Changes:
Differential Revision: D89943727