-
Notifications
You must be signed in to change notification settings - Fork 806
Arm backend: Update and enable ZephyrOS GitHub test #16539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Arm backend: Update and enable ZephyrOS GitHub test #16539
Conversation
This will test ZephyrOS by runing the commands in the README.md This verifies both the ZephyrOS support and make sure the instructions works. Signed-off-by: Zingo Andersen <[email protected]> Change-Id: I80a3cd658ff8e89fd52f0b934ea0bc3edc9da7dc
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16539
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit cc05833 with merge base 7793b1d ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Set git user/email so setup.sh can be runned. Signed-off-by: Zingo Andersen <[email protected]> Change-Id: Ie9a7b0c1a7135434f578d07e6df44c18aba73bea
3eb4c26 to
6ae6502
Compare
e336fc9 to
9965281
Compare
Signed-off-by: Zingo Andersen <[email protected]> Change-Id: Ib985416d356899e3edbc835b7468e95f2f6706e3
5b7d845 to
d55202a
Compare
|
Hi @SS-JIA and @metascroy this PR touched files outside Arm/Zephyr stuff e.g. install_executorch.sh This tests will run the code snippets in the Zephyr README.md so both ZephyrOS integration is testsed and that the README.md is up to date and work :) |
This removed dependancy to torchvision if not used as only the evaluator code need/uses it. Signed-off-by: Zingo Andersen <[email protected]> Change-Id: I4868945cd6957c898ec957daef004f48016945cb
d55202a to
c1a2818
Compare
Signed-off-by: Zingo Andersen <[email protected]> Change-Id: Ifee982a636472da756a2b1651ecd3842f8460a99
| #!/bin/bash | ||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| # All rights reserved. | ||
| # Copyright 2026 Arm Limited and/or its affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mergennachin is this okay to add an arm copyright to this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that's fine. whenever an entity touches or makes changes to a file, they can append their copyright too
| cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null || /bin/true | ||
| # Before doing anything, cd to the real path of the directory containing this script | ||
| # so we avoid repeated symlink segments in downstream CMake paths. | ||
| cd -- "$( realpath "$( dirname -- "${BASH_SOURCE[0]}" )" )" &> /dev/null || /bin/true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure this is okay
SS-JIA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
install_executorch.sh LGTM - I believe that's the only change outside Arm
| echo "===== Corstone300 FVP setup ====" | ||
| # Allowed only "export" command | ||
| run_command_block_from_zephyr_readme 'Config Zephyr Corstone300 FVP' '^export([[:space:]].*)$' | ||
| echo "---- Ethos-U55 ----" | ||
| rm -Rf build | ||
| # Allowed only "aot_arm_compiler" command | ||
| run_command_block_from_zephyr_readme 'Prepare the Ethos-U55 PTE model' '^python -m modules.lib.executorch.examples.arm.aot_arm_compiler([[:space:]].*)?$' | ||
| # Allowed only "west build" command | ||
| run_command_block_from_zephyr_readme 'Run the Ethos-U55 PTE model' '^west build([[:space:]].*)?$' | ||
| echo "---- Cortex-M55 ----" | ||
| rm -Rf build | ||
| # Allowed only "aot_arm_compiler" command | ||
| run_command_block_from_zephyr_readme 'Prepare the Cortex-M55 PTE model' '^python -m modules.lib.executorch.examples.arm.aot_arm_compiler([[:space:]].*)?$' | ||
| # Allowed only "west build" command | ||
| run_command_block_from_zephyr_readme 'Run the Cortex-M55 PTE model' '^west build([[:space:]].*)?$' | ||
| echo "===== Corstone320 FVP setup ====" | ||
| # Allowed only "export" command | ||
| run_command_block_from_zephyr_readme 'Config Zephyr Corstone320 FVP' '^export([[:space:]].*)$' | ||
| echo "---- Ethos-U85 ----" | ||
| rm -Rf build | ||
| # Allowed only "aot_arm_compiler" command | ||
| run_command_block_from_zephyr_readme 'Prepare the Ethos-U85 PTE model' '^python -m modules.lib.executorch.examples.arm.aot_arm_compiler([[:space:]].*)?$' | ||
| # Allowed only "west build" command | ||
| run_command_block_from_zephyr_readme 'Run the Ethos-U85 PTE model' '^west build([[:space:]].*)?$' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to set these up as separate tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, no problem, the setup time vs actual test time is the only downside as I see it. Can do it in this PR or in follow up PR?
Summary
This will test ZephyrOS by runing the commands in the README.md This verifies both the ZephyrOS support and make sure the instructions works.
Test plan
Include test in this PR
cc @freddan80 @per @oscarandersson8218 @digantdesai