Arm backend: Test fixes for TOSA on Arm64#20237
Open
zingo wants to merge 1 commit into
Open
Conversation
Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com> Change-Id: Ia8b796cb91c92ff45b36478d3b6904b25314f00c
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20237
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled Job, 2 Unclassified FailuresAs of commit df80895 with merge base 8dbbd9d ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Arm backend model tests to account for known numeric mismatches on aarch64 when running TOSA FP/BF16 paths, reducing spurious CI failures on Arm64 hosts.
Changes:
- Add an aarch64/arm64 host detection helper (
common.is_aarch64_host()). - Mark the ResNet18 TOSA BF16 test as xfail on aarch64 due to a known mismatch (MLETORCH-2048).
- Relax/xfail specific aarch64 cases for MobileNetV3 FP16 tolerance and Qwen3-VL BF16 vision patch embedding.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| backends/arm/test/common.py | Adds is_aarch64_host() helper for host-conditional test behavior. |
| backends/arm/test/models/test_resnet18.py | Xfails ResNet18 TOSA BF16 on aarch64 for known mismatch. |
| backends/arm/test/models/test_mobilenet_v3_arm.py | Adjusts FP16 atol on aarch64 (and adds a clarifying comment). |
| backends/arm/test/models/Qwen3_VL/test_qwen3_vl_layers.py | Adds per-case xfail for BF16 vision_patch_embed on aarch64. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pipeline.run() | ||
|
|
||
|
|
||
| # Different atol for TOSA on ARM (MLETORCH-2048: Large bf16 patch embedding mismatch on aarch64) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @digantdesai @freddan80 @per @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani