Skip to content

Revert "Build PyTorch wheel via PEP 517 instead of setup.py" (#21562) #21684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shoumikhin wants to merge 1 commit into from
+2 −12
Closed

Revert "Build PyTorch wheel via PEP 517 instead of setup.py" (#21562) #21684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions .ci/docker/common/install_pytorch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,18 +49,8 @@ install_pytorch_and_domains() {
export MAX_JOBS="${PYTORCH_BUILD_MAX_JOBS}"
fi
configure_pytorch_compiler
# PyTorch no longer supports "python setup.py bdist_wheel"; it now builds
# through scikit-build-core (PEP 517). Build the wheel with the standard
# frontend and keep build isolation off, so PyTorch builds against this
# environment's numpy and toolchain (avoids an ABI mismatch) and reuses
# sccache. With isolation off the frontend does not fetch the PEP 517 build
# requirements, so install the ones not already in the image here. Keep in
# sync with pytorch/pyproject.toml [build-system].requires.
# cmake stays below 4 because the wheel lands on PATH ahead of the image's
# cmake 3.x, so every later build in the image would jump a major version.
conda_run pip install build "scikit-build-core>=1.0" "setuptools>=77.0.0,<82" \
"cmake>=3.27,<4" ninja "packaging>=24.2" "typing-extensions>=4.10.0" pyyaml six
conda_run python -m build --wheel --no-isolation
# Then build and install PyTorch
conda_run python setup.py bdist_wheel
pip_install "$(echo dist/*.whl)"

# Grab the pinned audio and vision commits from PyTorch
Expand Down
Loading