fix pybind11 errors in cuda extension example#113
Merged
janeyx99 merged 1 commit intopytorch:masterfrom Jun 13, 2025
Merged
Conversation
dvrogozh
approved these changes
Jun 9, 2025
dvrogozh
left a comment
dvrogozh
left a comment
There was a problem hiding this comment.
LGTM. Do we know whom we need to ask to review/merge on maintainers side?
Contributor
Author
janeyx99
approved these changes
Jun 12, 2025
Contributor
janeyx99
left a comment
janeyx99
left a comment
There was a problem hiding this comment.
Changes looks fine to me, I haven’t yet verified locally but as the PR author is the issue opener I believe you already did?
Contributor
Author
|
Hi @janeyx99 , yes I've verified locally! |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #112