Migrate extension-cpp to stable API/ABI#126
Conversation
mikaylagawarecki
force-pushed
the
stable
branch
3 times, most recently
from
98ea688 to
75df317
Compare
|
|
||
| echo '::group::Install extension-cpp' | ||
| python setup.py develop | ||
| pip install -e . --no-build-isolation |
There was a problem hiding this comment.
This change was needed to get CI to run properly.
Otherwise, CI was installing the nightly but using torch 2.7 to build the extension
| runner: linux.g5.4xlarge.nvidia.gpu | ||
| gpu-arch-type: cuda | ||
| gpu-arch-version: "12.4" | ||
| gpu-arch-version: "12.9" |
There was a problem hiding this comment.
we no longer have cu nightlies for 12.4
There was a problem hiding this comment.
lol CI for this repo is so outdated
mikaylagawarecki
force-pushed
the
stable
branch
4 times, most recently
from
6f2afea to
ffab4c0
Compare
README.md
Outdated
| # C++/CUDA Extensions in PyTorch with LibTorch Stable ABI | ||
|
|
||
| An example of writing a C++/CUDA extension for PyTorch using the [LibTorch Stable ABI](https://pytorch.org/docs/main/notes/libtorch_stable_abi.html). | ||
| See [here](https://pytorch.org/tutorials/advanced/cpp_custom_ops.html) for the accompanying tutorial. |
There was a problem hiding this comment.
are we pushing for everyone to use libtorch stable abi? Or do we expect people will want to use the regular api? How do people select between the two?
IMO if we're not ready for literally everyone to move to libtorch stable abi right now, we should provide multiple examples. One for libtorch stable, and one without.
There was a problem hiding this comment.
@zou3519 We're pushing for people to use it as much as possible, but I agree that the coverage so far is not comprehensive enough for everyone to use it.
I've updated this PR to include both a stable and an unstable extension
mikaylagawarecki
force-pushed
the
stable
branch
from
ffab4c0 to
4185e93
Compare
mikaylagawarecki
force-pushed
the
stable
branch
from
4185e93 to
f65fba3
Compare
…3701) ## Description Migrate `advanced_source/cpp_custom_ops.rst` to libtorch stable ABI/API. Accompanying change to [`extension-cpp`](pytorch/extension-cpp#126) cc @zou3519 --------- Co-authored-by: Alanna Burke <burkealanna@meta.com> Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
2 participants
Accompanying tutorials change pytorch/tutorials#3701