ci: fix forked PR checkout & harden pull_request_target#11
Merged
keerthi-go merged 1 commit intoqualcomm-linux:mainfrom Mar 26, 2026
Merged
Conversation
- Replace `ref: ${{ github.head_ref }}` with a fork-safe checkout using:
`repository: ${{ github.event.pull_request.head.repo.full_name }}`
`ref: ${{ github.event.pull_request.head.sha }}`
`persist-credentials: false`
- Keep default checkout for push/schedule/workflow_dispatch
- Split build step so PRs never receive secrets or push to GHCR
- Remove stray text after `username:` input
Rationale:
- `github.head_ref` assumes the branch exists in the base repo; for forked PRs, it points to a non-existent branch or the wrong repo.
- `pull_request_target` runs with base-repo context; avoiding persisted Git credentials and withholding secrets prevents token/secrets exposure.
- Ensures PR validation builds against the contributor’s Dockerfiles while only publishing images on trusted events.
Affected file:
- .github/workflows/qcom-container-build-and-upload.yml
Signed-off-by: Bjordis Collaku <bcollaku@qti.qualcomm.com>
keerthi-go
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the container build workflow fork-safe and reduces risk on
pull_request_target. For PRs, the job now checks out the fork’s exact head commit using the event payload and disables credential persistence; for trusted events (push,schedule,workflow_dispatch), it uses the default checkout. The build step is split so PR validations never receive secrets or push to GHCR, while trusted events continue to publish images. Also cleans a stray token username line.head.repo+head.sha,persist-credentials: false, build only (no push, no secrets).