userspace-resource-manager: Modify test runner for URM by kartnema · Pull Request #352 · qualcomm-linux/qcom-linux-testkit

kartnema · 2026-03-17T06:15:43Z

Update the existing test runner for resource-tuner:

Changes to reflect project name change from resource-tuner to userspace-resource-manager.
Modify the list of test executables to be executed as part of automated testing.
Test Runner changes to use configs in /etc/urm/tests rather than /etc/urm/custom

smuppand · 2026-03-17T10:16:18Z

Runner/suites/Performance/userspace-resource-manager/run.sh

+    # base config requirement: accept common OR tests; skip only if BOTH missing
    if suite_requires_base_cfgs "$name"; then
-        if [ $COMMON_OK -eq 0 ] && [ $CUSTOM_OK -eq 0 ]; then
+        if [ $COMMON_CONFIGS_OK -eq 0 ] && [ $TEST_CONFIGS_OK -eq 0 ] && [ $TEST_NODES_OK -eq 0 ]; then


I think this changes the gating semantics in a risky way. tests/nodes looks like a required input for the URM suites, but with this condition the suite will still run when configs are present and tests/nodes is missing. Should the nodes check remain a separate per-suite skip, instead of being folded into the “all three missing” condition?

For the update test suites, both tests/nodes and tests/configs are required input, in addition to common configs.

The goal is since, running test case with tests/nodes present but tests/configs (or the other way around) does not make sense, hence a more exhaustive check needs to be added to see if all 3 requirements are satisfied. I'll make the code level checks, and change the comments as appropriate.

smuppand · 2026-03-17T10:17:12Z

Runner/suites/Performance/userspace-resource-manager/run.sh

    if suite_requires_base_cfgs "$name"; then
-        if [ $COMMON_OK -eq 0 ] && [ $CUSTOM_OK -eq 0 ]; then
+        if [ $COMMON_CONFIGS_OK -eq 0 ] && [ $TEST_CONFIGS_OK -eq 0 ] && [ $TEST_NODES_OK -eq 0 ]; then
            log_skip "[CFG] Base configs missing (common/ AND custom/) — skipping $name"


This still says custom/, but the new path is tests/configs. Please update the message so runtime logs match the new layout.

smuppand · 2026-03-25T05:56:00Z

Runner/suites/Performance/userspace-resource-manager/run.sh

 #!/bin/sh
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
-# SPDX-License-Identifier: BSD-3-Clause# resource-tuner test runner (pinned whitelist)
+# SPDX-License-Identifier: BSD-3-Clause# userspace-resource-manager test runner (pinned whitelist)


Please split this into two separate comment lines so the SPDX tag stays valid and parseable.

smuppand · 2026-03-25T05:56:53Z

Runner/suites/Performance/userspace-resource-manager/run.sh

-SUITES_REQUIRE_BASE_CFGS="ResourceProcessorTests SignalConfigProcessorTests SysConfigAPITests \
-ExtFeaturesParsingTests TargetConfigProcessorTests InitConfigParsingTests \
-ResourceParsingTests ExtensionIntfTests resource_tuner_tests"
+# Suites that need base configs (accept either common/ OR tests/)


The current logic below requires all of common/, tests/configs, and tests/nodes. Please update the comment so it matches the actual behavior.

smuppand · 2026-03-25T05:58:01Z

Runner/suites/Performance/userspace-resource-manager/run.sh

  - Service INACTIVE => overall SKIP (end early)
-  - Base configs: suites require common/ OR custom/ (skip only if BOTH missing)
-  - resource_tuner_tests additionally needs tests/Configs/ResourceSysFsNodes
+  - Base configs: suites require common/ OR tests/ (skip only if BOTH missing)


print_usage() is still describing the old semantics
but the implementation now skips when any of common/, tests/configs, or tests/nodes is missing. Please update the usage text so runtime help matches the current logic.

smuppand · 2026-03-25T05:59:03Z

Runner/suites/Performance/userspace-resource-manager/README.md

  - `InitConfig.yaml`, `PropertiesConfig.yaml`, `ResourcesConfig.yaml`, `SignalsConfig.yaml`

- `custom/` (required files):
+- `tests/configs/` (required files):


The tests/configs/ required-file list is missing Baseline.yaml, but run.sh currently requires it through RT_REQUIRE_TEST_FILES. Please add Baseline.yaml here so the README matches the implementation.

Done, also renamed RT_REQUIRE_TEST_FILES to URM_REQUIRE_TEST_FILES, to align with project naming

smuppand · 2026-03-25T05:59:43Z

Runner/suites/Performance/userspace-resource-manager/README.md

  - `InitConfig.yaml`, `PropertiesConfig.yaml`, `ResourcesConfig.yaml`, `SignalsConfig.yaml`, `TargetConfig.yaml`, `ExtFeaturesConfig.yaml`

-If **both** trees are missing required files/dirs, config‑parsing suites are **SKIP** only (neutral).
+- `tests/nodes/` (required files):


the runner checks that tests/nodes/ is present and non-empty, not that it contains a specific required file list. Please reword this to something like “must exist and be non-empty” for clarity.

smuppand · 2026-03-25T06:00:48Z

Runner/suites/Performance/userspace-resource-manager/README.md

- `RT_REQUIRE_COMMON_FILES`, `RT_REQUIRE_CUSTOM_FILES`: *space‑separated* filenames that must exist in `common/` / `custom/` respectively to treat that tree as present.
+- `SERVICE_NAME`: systemd unit to check (default: `urm.service`)
+- `RT_CONFIG_DIR`: root of config tree (default: `/etc/urm`)
+- `RT_REQUIRE_COMMON_FILES`, `RT_REQUIRE_CUSTOM_FILES`: *space‑separated* filenames that must exist in `common/` / `tests/` respectively to treat that tree as present.


The environment override names here are out of sync with the script:

README says RT_CONFIG_DIR

run.sh uses URM_CONFIG_DIR

README says RT_REQUIRE_CUSTOM_FILES

run.sh uses RT_REQUIRE_TEST_FILES

Please update this section so the documented variable names match the actual implementation
introvert.com

smuppand · 2026-03-25T06:02:17Z

Runner/suites/Performance/userspace-resource-manager/README.md

the script now reads URM_CONFIG_DIR. Please update the example accordingly

smuppand · 2026-03-25T06:02:52Z

Runner/suites/Performance/userspace-resource-manager/README.md

 ## Exit status

-The script writes the overall result to `resource-tuner.res`. The **process exit code is 0** in all cases in the current version (soft gating). If you want hard CI gating via non‑zero exit on FAIL, that can be added easily on request.
+The script writes the overall result to `userspace-resource-manager.res`. The **process exit code is 0** in all cases in the current version (soft gating). If you want hard CI gating via non‑zero exit on FAIL, that can be added easily on request.


Current run.sh exits 1 on overall FAIL. Please update the Exit status section to match the actual behavior.

smuppand · 2026-03-25T15:22:39Z

Runner/suites/Performance/userspace-resource-manager/run.sh

 #!/bin/sh
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
-# SPDX-License-Identifier: BSD-3-Clause# resource-tuner test runner (pinned whitelist)
+# SPDX-License-Identifier: BSD-3-Clause#


Tiny clean up it should just be # SPDX-License-Identifier: BSD-3-Clause

Signed-off-by: Kartik Nema <kartnema@qti.qualcomm.com>

smuppand

LGTM

kartnema marked this pull request as draft March 17, 2026 06:15

kartnema force-pushed the main branch from 3f63f7a to a958706 Compare March 17, 2026 06:29

kartnema changed the title ~~Modify test runner for URM~~ userspace-resource-manager: Modify test runner for URM Mar 17, 2026

kartnema marked this pull request as ready for review March 17, 2026 06:40

smuppand requested changes Mar 17, 2026

View reviewed changes

kartnema force-pushed the main branch 2 times, most recently from 0c9e298 to 3032b45 Compare March 24, 2026 09:02

kartnema requested a review from smuppand March 24, 2026 09:02

smuppand requested changes Mar 25, 2026

View reviewed changes

kartnema force-pushed the main branch 2 times, most recently from 2226fa5 to 638b174 Compare March 25, 2026 08:39

smuppand requested changes Mar 25, 2026

View reviewed changes

Modify test runner for URM

abf61e0

Signed-off-by: Kartik Nema <kartnema@qti.qualcomm.com>

kartnema force-pushed the main branch from 638b174 to abf61e0 Compare March 26, 2026 05:12

smuppand approved these changes Mar 26, 2026

View reviewed changes

smuppand merged commit 1991e58 into qualcomm-linux:main Mar 26, 2026
12 checks passed

Conversation

kartnema commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kartnema commented Mar 17, 2026 •

edited

Loading