qrb2210-unoq: update partitions based on the edk2-downstream boot fir…#103
qrb2210-unoq: update partitions based on the edk2-downstream boot fir…#103ricardosalveti wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
…mware Update filenames based on the new edk2-downstream boot firmware release available at [1], and remove partitions which are not used / required anymore. Removing should not cause any impact on current users, as they will simply not be used anymore. [1] https://softwarecenter.qualcomm.com/nexus/generic/product/chip/tech-package/QRB2210_bootbinaries.1.0/qrb2210_bootbinaries.1.0-test-device-public/00010/Agatti_bootbinaries.zip Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
|
Created as draft as it is still pending validation. |
|
Thanks! Should we consider tweaking partition sizes to align with other QLI platforms and have comparable budgets for newly flashed devices? The Arduino version of the file might be constrained in keeping the location of the userdata partition. This might be a good opportunity to add the other two hardware partitions, with blank filenames for MAC addresses: |
That will imply a significant difference in the partition table, which is not nice for users coming from an older release, but I guess we have a bit more freedom with the non-arduino partition file. |
|
I would prefer separating the partition reduction and major changes from this PR, as then we can trace regressions and issues easily, since it will be a major and breaking change. |
ricardosalveti
requested review from
lumag,
ndechesne,
sbanerjee-quic and
vkraleti
as code owners
|
Validated with qualcomm-linux/meta-qcom-3rdparty#28. |
|
@ricardosalveti are you also planning to update for RB1 here: https://github.com/qualcomm-linux/qcom-ptool/blob/main/platforms/qrb2210-rb1/emmc/partitions.conf? |
| --partition --name=keymaster_a --size=512KB --type-guid=A11D2A7C-D82A-4C2F-8A01-1805240E6626 --filename=km4.mbn | ||
| --partition --name=keymaster_b --size=512KB --type-guid=77036CD4-03D5-42BB-8ED1-37E5A88BAA34 --filename=km4.mbn | ||
| --partition --name=keymaster_a --size=512KB --type-guid=A11D2A7C-D82A-4C2F-8A01-1805240E6626 | ||
| --partition --name=keymaster_b --size=512KB --type-guid=77036CD4-03D5-42BB-8ED1-37E5A88BAA34 |
There was a problem hiding this comment.
Also, why do we need to keep it? What if there is an old binary still present there?
There was a problem hiding this comment.
I don't think it would be used, but I would have to confirm with the boot team.
We have keymaster in every target, and we also don't have km4.mdn for them, so unclear if this is really needed or if we can drop from our default partition list, have to check with the team.
| --partition --name=featenabler_a --size=128KB --type-guid=741813D2-8C87-4465-8C69-032C771CCCE7 --filename=featenabler.mbn | ||
| --partition --name=featenabler_b --size=128KB --type-guid=77036CD4-03D5-42BB-8ED1-37E5A88BAA34 --filename=featenabler.mbn | ||
| --partition --name=devcfg_a --size=128KB --type-guid=F65D4B16-343D-4E25-AAFC-BE99B6556A6D --filename=devcfg_iot.mbn | ||
| --partition --name=devcfg_b --size=128KB --type-guid=169534E7-7809-4240-9763-0BA5DC37B5FF --filename=devcfg_iot.mbn |
There was a problem hiding this comment.
Why is it _iot? Can't we have unified devcfg.mbn?
There was a problem hiding this comment.
right. that's suspicious. i would rather fixup in the firmware recipe and keep devcfg (and report the issue)
There was a problem hiding this comment.
This is just the pattern they are using, we also have this with other targets:
platforms/qcs615-ride/ufs/partitions.conf:--partition --lun=4 --name=devcfg_a --size=128KB --type-guid=F65D4B16-343D-4E25-AAFC-BE99B6556A6D --filename=devcfg_iot.mbn
platforms/iq-8275-evk/ufs/partitions.conf:--partition --lun=4 --name=devcfg_a --size=128KB --type-guid=F65D4B16-343D-4E25-AAFC-BE99B6556A6D --filename=devcfg_iot.mbn
platforms/qcs9100-ride-sx/ufs/partitions.conf:--partition --lun=4 --name=devcfg_a --size=128KB --type-guid=F65D4B16-343D-4E25-AAFC-BE99B6556A6D --filename=devcfg_iot.mbn
platforms/iq-615-evk/ufs/partitions.conf:--partition --lun=4 --name=devcfg_a --size=128KB --type-guid=F65D4B16-343D-4E25-AAFC-BE99B6556A6D --filename=devcfg_iot.mbn
platforms/qcs8300-ride-sx/ufs/partitions.conf:--partition --lun=4 --name=devcfg_a --size=128KB --type-guid=F65D4B16-343D-4E25-AAFC-BE99B6556A6D --filename=devcfg_iot.mbn
platforms/iq-9075-evk/ufs/partitions.conf:--partition --lun=4 --name=devcfg_a --size=128KB --type-guid=F65D4B16-343D-4E25-AAFC-BE99B6556A6D --filename=devcfg_iot.mbn
Yes, checking this one today. |
5 participants
…mware
Update filenames based on the new edk2-downstream boot firmware release available at [1], and remove partitions which are not used / required anymore.
Removing should not cause any impact on current users, as they will simply not be used anymore.
[1]
https://softwarecenter.qualcomm.com/nexus/generic/product/chip/tech-package/QRB2210_bootbinaries.1.0/qrb2210_bootbinaries.1.0-test-device-public/00010/Agatti_bootbinaries.zip