Skip to content

Conversation

@sergeisakov
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the size: XL lines changed >1000 label Dec 16, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds experimental support for cuStateVecEx, which is a great addition for multi-GPU and multi-node simulations. The changes are extensive, touching build systems, the Python interface, and adding a significant amount of new C++ code.

I've found several critical issues in the build files (Makefile, CMakeLists.txt, BUILD) that will prevent the code from compiling or linking correctly. There's also a compilation error in apps/qsim_base_custatevecex.cu.

Additionally, there are several violations of the C++ style guide regarding C-style casts, which should be replaced with C++-style casts (static_cast, reinterpret_cast). I've pointed out one instance per file and requested that all occurrences be fixed. There's also a code smell with const_cast that could be improved with a better design.

Please address these issues to ensure the new functionality is robust and maintainable. The addition of tests for the new backend is much appreciated.

@sergeisakov sergeisakov requested a review from mhucka December 22, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XL lines changed >1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant