Fix Windows installation error handling #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Scoop fails to download or install Quarto (e.g., 503 server errors), the action would still report "Quarto Installed !" and succeed. The PowerShell script had no error handling and the bash wrapper didn't check exit codes, causing installation failures to be silently ignored.
The PowerShell script already verifies Quarto is available with Get-Command. The bash check was redundant and failing because GITHUB_PATH updates only take effect in subsequent steps, not within the same step where the PATH is modified.
The Get-Command verification was failing because $GITHUB_PATH only affects future steps, not the current PowerShell session. Now we also update $env:PATH so the verification can find quarto.
Previously each OS had different verification approaches: - Windows: PowerShell Get-Command check (failed due to PATH timing) - Linux/macOS: No verification Now all platforms use a single bash verification step that runs after installation. This works because GITHUB_PATH updates take effect in subsequent steps, not within the same step.
Scoop commands leave $LASTEXITCODE in unpredictable states even on success. With $ErrorActionPreference = "Stop", real errors will be caught automatically. The separate bash verification step confirms installation succeeded.
This reverts commit a144809.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Scoop fails to download or install Quarto (e.g., 503 server errors), the action would still report "Quarto Installed !" and succeed.
The PowerShell script had no error handling and the bash wrapper didn't check exit codes, causing installation failures to be silently ignored.
This PR fixes that