test: enhance error reporting and grouping in test execution inside Github Action #13787
+236
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub Action This hopefully ease the read of test logs inside github actions
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Enhance smoke test CI logs for better error visibility and reduced browser load: - Add GitHub Actions error annotations with file paths and test names - Implement workflow-level log grouping (collapsed by default) - Gate verbose shell script messages behind RUNNER_DEBUG or QUARTO_TEST_VERBOSE - Fix Linux CI to run all tests in bucket (no fail-fast) and report failures at end - Update Windows CI to match Linux behavior (collect all failures before exiting)
CI annotations show which tests failed but don't help locate the failure in logs with thousands of lines. Users need to manually scroll through output to find the actual error.
Need to verify that failure markers and annotation improvements work correctly in CI logs before finalizing changes.
Collaborator
Author
|
Triggering a test with the failing one in the middle to see if we can navigate to it easily: https://github.com/quarto-dev/quarto-cli/actions/runs/20174970499 |
Bucket-level error annotations were emitted inside ::group::...::endgroup:: blocks, making them invisible when groups are collapsed. Users had to expand each group to see which buckets failed. Move ::endgroup:: before the error check so bucket failure annotations appear outside the collapsed group and are immediately visible.
Collaborator
Author
…owerShell scripts.
Collaborator
Author
|
So this is what we see now This is the same on Windows. See detailed log at quarto-dev/quarto-cli/actions/runs/20226090577 |
Moves GitHub Actions workflow command helpers from tests/ to src/tools/ so they can be used throughout the codebase to reduce ungrouped log lines. The consolidated helpers include proper escaping for workflow commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at improving readability of CI logs on failures. Idea is to navigate more easily to failing tests, and also have Windows and Linux behave the same. Difference in behavior is about the default for shell execution on error. See https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#exit-codes-and-error-action-preference for details (basically CMD does not fail fast by default unlike bash and pwsh shells on github action)