detect and warn about x64 R on Windows ARM #13790
Draft
+83
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When x64 R fails on Windows ARM, parse YAML output to detect the architecture mismatch and provide a specific error message with ARM64 R download links instead of the generic "check your R installation" message. Also adds platform information to quarto check output with warning when x64 R is detected on ARM Windows.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
and general instructions for installing ARM64 R on Windows ARM rather than using specific links.
x64 R on Windows ARM is intermittently unstable under emulation - the same command can succeed on first call but crash on second call. Previous detection only ran when capabilities check failed, missing successful checks. Now detects x64-on-ARM in both success and failure paths, ensuring consistent error message regardless of intermittent emulation behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Eliminates code duplication by extracting checkWindowsArmR() helper: - Single source of truth for platform check - Called in both success and failure paths - Fixed error handling to preserve helpful error messages - Removed dead warning code from knitrCapabilitiesMessage Behavior unchanged: still throws error on x64 R detection.
Replace string matching with type-safe instanceof checks: - Add WindowsArmX64RError custom error class - Update checkWindowsArmR() to throw custom error - Replace e.message.includes() checks with instanceof More robust and follows TypeScript best practices.
Catch WindowsArmX64RError in knitrCb before withSpinner can swallow it, then display the custom error message instead of the generic message. This ensures users see the helpful x64-on-ARM error with download links instead of "Please check your installation of R."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When x64 R fails on Windows ARM, parse YAML output to detect the architecture mismatch and provide a specific error message with ARM64 R download links instead of the generic "check your R installation" message.
Also adds platform information to quarto check output with warning when x64 R is detected on ARM Windows.
This is draft PR because I need to check this work as expected in windows ARM runner