all: initial support for freebsd #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigsaltyfishes
force-pushed
the
master
branch
3 times, most recently
from
1b2d54f to
4c97caa
Compare
Member
|
This is still marked as draft, is it ready for review? |
Contributor
Author
|
Sorry for my late reply, i finished the test just now, should work on freebsd now. |
outfoxxed
reviewed
Dec 23, 2025
Comment on lines
+90
to
+94
| #ifdef __FreeBSD__ | ||
| auto result = pam_start(config, user, &conv, &handle); | ||
| #else | ||
| auto result = pam_start_confdir(config, user, &conv, configDir, &handle); | ||
| #endif |
Member
There was a problem hiding this comment.
If pam can't be configured on bsd a note of that should be made on the configdir property
quickshell/src/services/pam/qml.hpp
Line 39 in 3918290
- Added FreeBSD CI. - Use `copy_file_range(2)` over `sendfile(2)` which has wider compatibility. - Special case pam on freebsd and document `configDirectory` incompatibility. - Disable jemalloc for FreeBSD by default as it is the system allocator. - Disable breakpad by default on FreeBSD as breakpad is not supported.
Member
|
Dropped the link dirs, which I am not opposed to re-adding if it is actually the convention. Usually those paths are configured via the system and I haven't seen other packages do that. Otherwise LGTM |
Member
|
CI setup also failed on merge, so I've currently excluded it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial support for FreeBSD.