Use local_package_copy() for test writing to test path#1685
Merged
hadley merged 1 commit intor-lib:mainfrom Mar 2, 2026
Merged
Use local_package_copy() for test writing to test path#1685hadley merged 1 commit intor-lib:mainfrom
hadley merged 1 commit intor-lib:mainfrom
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our test environment does not have write permissions, causing this to fail.
Usually I ignore these issues, but in this case {roxygen2} already has a relevant helper, it's just not being used in this case (probably because the test is of idempotency --> the test package is not expected to change at all).
I am proposing the change here for consistency sake, but it's not strongly motivated besides our use case -- feel free to close :)