CQ: Use open_eventually in recovery (backport #15136) (backport #15167) #15168
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for Windows to be so stubborn that the file can't be opened after open_eventually has given up, which causes a crash and force the queue to be restarted, then trying to open that same file during recovery still errors out. Using open_eventually there may or may not help. Also use open_eventually in queue store's get_read_fd as a crash log has shown it can happen there as well. (cherry picked from commit ba71e66) (cherry picked from commit 5f316df)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for Windows to be so stubborn that the file can't be opened after open_eventually has given up, which causes a crash and force the queue to be restarted, then trying to open that same file during recovery still errors out.
Using open_eventually there may or may not help.
Also use open_eventually in queue store's get_read_fd as a crash log has shown it can happen there as well.
#15134
Note that this isn't a "real fix" but just more workarounds for some annoying Windows behavior.
This is an automatic backport of pull request #15136 done by Mergify.
This is an automatic backport of pull request #15167 done by Mergify.