Null-proof message ignored listener #903
Merged
+12
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message ignored listener in the consumer coordinator calls the processed method on ignored messages to "simulate" the processing (e.g. increment a counter to provide a credit in the middle of the chunk). The MessageProcessedCallback is the chunk context in this case, which can be null, depending on the consumer flow strategy. The listener could trigger a null-pointer exception by calling the processed method on the context. This commit adds a null check to avoid the null-pointer exception. A null chunk context (MessageProcessedCallback) means the custom behavior of the consumer flow strategy is performed when the chunk starts, so the call to MessageHandler.Context#processed() is not necessary.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
…ener Null-proof message ignored listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message ignored listener in the consumer coordinator calls the processed method on ignored messages to "simulate" the processing (e.g. increment a counter to provide a credit in the middle of the chunk).
The MessageProcessedCallback is the chunk context in this case, which can be null, depending on the consumer flow strategy. The listener could trigger a null-pointer exception by calling the processed method on the context.
This commit adds a null check to avoid the null-pointer exception. A null chunk context (MessageProcessedCallback) means the custom behavior of the consumer flow strategy is performed when the chunk starts, so the call to MessageHandler.Context#processed() is not necessary.