-
Notifications
You must be signed in to change notification settings - Fork 9
feat(openstack): Updates OpenStack services for RabbitMQ v4 #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,6 +59,18 @@ conf: | |
| # this is where we populate our hardware | ||
| project_domain_name: infra | ||
| project_name: baremetal | ||
| oslo_messaging_notifications: | ||
| driver: messagingv2 | ||
| oslo_messaging_rabbit: | ||
| amqp_durable_queues: true | ||
| rabbit_ha_queues: false | ||
| rabbit_quorum_queue: true | ||
| rabbit_transient_quorum_queue: true | ||
| rabbit_qos_prefetch_count: 1 | ||
| use_queue_manager: true | ||
| rabbit_stream_fanout: true | ||
| oslo_concurrency: | ||
| lock_path: /var/lock | ||
nicholaskuechler marked this conversation as resolved.
Show resolved
Hide resolved
Comment on lines
+72
to
+73
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Delete these two lines. This isn't part of RabbitMQ configs. This is a value that's set and configured in the default upstream chart so now this snippet is wrong. |
||
| nova: | ||
| quota: | ||
| # adjust default quotas to make it possible to use baremetal | ||
|
|
@@ -76,8 +88,16 @@ conf: | |
| ironic: | ||
| api_max_retries: 90 # number of times to retry. default is 60. | ||
| api_retry_interval: 10 # number of sesconds between retries. default is 2. | ||
| oslo_messaging_notifications: | ||
| driver: messagingv2 | ||
| oslo_messaging_rabbit: | ||
| amqp_durable_queues: true | ||
| rabbit_ha_queues: false | ||
| rabbit_quorum_queue: true | ||
| rabbit_transient_quorum_queue: true | ||
| rabbit_qos_prefetch_count: 1 | ||
| use_queue_manager: true | ||
| rabbit_stream_fanout: true | ||
|
|
||
| # https://docs.openstack.org/nova/2025.2/admin/scheduling.html#the-filter-scheduler | ||
| filter_scheduler: | ||
|
|
@@ -93,10 +113,6 @@ conf: | |
| uwsgi: | ||
| processes: 2 | ||
|
|
||
| # Enable oslo.messaging notifications for Argo Events integration | ||
| oslo_messaging_notifications: | ||
| driver: messagingv2 | ||
|
|
||
| console: | ||
| # we are working with baremetal nodes and not QEMU so we don't need novnc or spice | ||
| # connected to QEMU | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ metadata: | |
| spec: | ||
| replicas: 3 | ||
| persistence: {{ .Values.rabbitmq.persistence | toJson }} | ||
| image: {{ .Values.rabbitmq.image | default "rabbitmq:3.13.7-management" }} # renovate:ignore | ||
| image: {{ .Values.rabbitmq.image | default "rabbitmq:4.1.1-management" }} # renovate:ignore | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can get quorum queues with 3.13.7 which is the transitory version so I would remove this piece and we can do it in a follow on. |
||
| resources: {{ .Values.rabbitmq.resources | toJson }} | ||
| affinity: | ||
| nodeAffinity: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this setting be brought to some of the other services?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we even need it here. The reference specifically mentions neutron, but this is for large-scale openstack deployments, which we are nowhere near. The default ttl is 30 minutes anyways. 🤷