feat: add virtualization cluster type, group, and cluster sync support#1868
Merged
abhimanyu003 merged 2 commits intomainfrom Mar 26, 2026
Merged
feat: add virtualization cluster type, group, and cluster sync support#1868abhimanyu003 merged 2 commits intomainfrom
abhimanyu003 merged 2 commits intomainfrom
Conversation
abhimanyu003
commented
Mar 25, 2026
| // ConfigMapRef defines a reference to a specific ConfigMap | ||
| type ConfigMapRef struct { | ||
| // Name of this config set (logical name) | ||
| Name string `json:"name"` |
Contributor
Author
There was a problem hiding this comment.
Removing this Name fields as it's dead weight. It adds a required field to the CRD that users have to fill in but the operator never reads.
It creates confusion too, since both ConfigMapRef.Name and ConfigMapRef.ConfigMapSelector.Name exist as "name" at different nesting levels in the YAML.
haseebsyed12
approved these changes
Mar 26, 2026
0b480b3 to
d3edc5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces full CRUD sync support to three new resource types
Sample YAML
Cluster types:
Cluster groups:
Clusters:
CR spec additions
The Nautobot custom resource now accepts three new optional refs: