Custom sounds requested features #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds feature requested in rafaelmardojai#347 and drops deprecated FileChooserNative in favor of the new FileDialog.
Adds feature requested in rafaelmardojai#337.
Change the default custom sound's name to the full filename without the extension.
Fixes rafaelmardojai#361. I'm not sure if this implementation is the best.
Owner
|
Will try to review this in the weekend, I have been short of time these months, sorry for the wait. |
Owner
|
Sorry it took so long, thanks a lot for taking the time. Everything looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the features requested in:
And fixes:
It also shrinks the renaming dialogs' height to better hug the content.
New POT entries:
Screenshots:
(I do not know why the default adwaita theme is not applied properly when running from GNOME Builder)
Multiple audio selection:
Renaming on popdown:
Renaming dialog:
