fix: use withdraw4 for Orderbook V6 in intra-orderbook calldata#437
Open
Siddharth2207 wants to merge 2 commits into2026-02-12-sushi-price-impactfrom
Open
fix: use withdraw4 for Orderbook V6 in intra-orderbook calldata#437Siddharth2207 wants to merge 2 commits into2026-02-12-sushi-price-impactfrom
Siddharth2207 wants to merge 2 commits into2026-02-12-sushi-price-impactfrom
Conversation
The getCalldata dispatch was falling through to getCalldataForV4Order for all V4 orders, which hardcodes withdraw3 (V5). V6 replaced withdraw3 with withdraw4, causing a revert. Added getCalldataForV4OrderV6 using the V6 ABI and updated the dispatch to route V6 pairs correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Picks up rainlanguage/sushiswap#44 so wtMSTR (and other tokens only paired with cbBTC on Hydrex) can be priced in ETH terms by the solver. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rouzwelt
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCalldatawas routing all V4 orders togetCalldataForV4Order, which hardcodeswithdraw3(Orderbook V5)withdraw3withwithdraw4, causing a revert in the multicallgetCalldataForV4OrderV6usingABI.Orderbook.V6.Primary.Orderbookwithwithdraw4andclear3Pair.isV4OrderbookV6before falling through to the V5 pathlib/sushiswapsubmodule to1b2b675(add cbBTC to Base routing bases sushiswap#44) — adds cbBTC to Base routing bases so tokens only paired with cbBTC on Hydrex (e.g. wtMSTR) can be priced in ETH terms