RDKB-64757 : Remotedebugger debug.txt getting appended while repeatedly query same issueype by Abhinavpv28 · Pull Request #187 · rdkcentral/remote_debugger

Abhinavpv28 · 2026-05-02T07:03:01Z

No description provided.

Abhinavpv28 · 2026-05-02T07:03:43Z

@copilot
12:15:13 | ../../git/src/rrdRunCmdThread.c: In function 'executeCommands':
12:15:13 | ../../git/src/rrdRunCmdThread.c:380:97: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size 240 [-Werror=format-truncation=]
12:15:13 | 380 | snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr), "%s%s", remoteDebuggerPrefix, dirname);
12:15:13 | | ^~ ~~~~~~~
12:15:13 | ../../git/src/rrdRunCmdThread.c:380:25: note: 'snprintf' output between 17 and 272 bytes into a destination of size 256
12:15:13 | 380 | snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr), "%s%s", remoteDebuggerPrefix, dirname);
12:15:13 | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
12:15:13 | cc1: al

github-actions · 2026-05-02T07:04:12Z

Code Coverage Summary

                               Total:|83.5%   5888|97.0%  1531|    -      0

Copilot

Pull request overview

This PR updates executeCommands() in the remote debugger runtime flow, apparently to change how per-request output files are opened and to make the transient systemd-run unit name derive from the per-execution directory name rather than just the RFC value. In the broader codebase, this sits in the command-execution path that collects debug output and uploads it for a requested issue.

Changes:

Open each request’s debug_outputs.txt with "w+" instead of "a+".
Build the systemd-run/journalctl/systemctl stop unit name with remote_debugger_ + dirname.
Leave the previous strncpy/strncat unit-name construction in commented form.

…F_LEN_512 Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/f3e6d001-a244-4693-b073-fad00bcf7bf7 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot · 2026-05-02T07:11:40Z

@copilot
12:15:13 | ../../git/src/rrdRunCmdThread.c: In function 'executeCommands':
12:15:13 | ../../git/src/rrdRunCmdThread.c:380:97: error: '%s' directive output may be truncated writing up to ...

Fixed in commit 02ad766.

The root cause: remoteDebuggerServiceStr was declared as BUF_LEN_256 (256 bytes), but the snprintf concatenates remoteDebuggerPrefix ("remote_debugger_", 16 chars) with dirname (up to 255 chars), requiring up to 272 bytes — exceeding the destination buffer.

Changes made:

Added #define BUF_LEN_512 512 to rrdRunCmdThread.h
Changed remoteDebuggerServiceStr buffer from BUF_LEN_256 to BUF_LEN_512
Removed the dead commented-out code

github-actions · 2026-05-04T16:40:27Z

Code Coverage Summary

                               Total:|83.5%   5888|97.0%  1531|    -      0

github-actions · 2026-05-04T16:45:39Z

Code Coverage Summary

                               Total:|83.5%   5888|97.0%  1531|    -      0

github-actions · 2026-05-04T16:46:19Z

Code Coverage Summary

                               Total:|83.5%   5888|97.0%  1531|    -      0

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

AravindanNC

are multiple command outputs present in the upload file ?

github-actions · 2026-05-05T02:54:51Z

Code Coverage Summary

                               Total:|83.5%   5892|97.0%  1531|    -      0

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

github-actions · 2026-05-05T03:23:40Z

Code Coverage Summary

                               Total:|83.5%   5892|97.0%  1531|    -      0

github-actions · 2026-05-05T04:31:19Z

Code Coverage Summary

                               Total:|83.5%   5892|97.0%  1531|    -      0

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

+                RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service failed!!!\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr);
            }
            else
            {
-                RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service success...\n",__FUNCTION__,__LINE__,cmdData->rfcvalue);
+                RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service success...\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr);


github-actions · 2026-05-05T04:38:31Z

Code Coverage Summary

                               Total:|83.5%   5892|97.0%  1531|    -      0

github-actions · 2026-05-05T12:05:29Z

Code Coverage Summary

                               Total:|83.5%   5892|97.0%  1531|    -      0

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

-            strncpy(remoteDebuggerServiceStr, remoteDebuggerPrefix, sizeof(remoteDebuggerServiceStr) - 1);
-            remoteDebuggerServiceStr[sizeof(remoteDebuggerServiceStr) - 1] = '\0';
-            strncat(remoteDebuggerServiceStr, cmdData->rfcvalue, sizeof(remoteDebuggerServiceStr) - strlen(remoteDebuggerServiceStr) - 1);
+            snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr),"%s%s_%ld", remoteDebuggerPrefix, cmdData->rfcvalue, (long)epochTime);


+            time_t epochTime = time(NULL);
+            if (epochTime == ((time_t)-1))
+            {
+                RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Failed to get epoch time\n", __FUNCTION__, __LINE__);
+                return false;
+            }

-            strncpy(remoteDebuggerServiceStr, remoteDebuggerPrefix, sizeof(remoteDebuggerServiceStr) - 1);
-            remoteDebuggerServiceStr[sizeof(remoteDebuggerServiceStr) - 1] = '\0';
-            strncat(remoteDebuggerServiceStr, cmdData->rfcvalue, sizeof(remoteDebuggerServiceStr) - strlen(remoteDebuggerServiceStr) - 1);
+            snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr),"%s%s_%ld", remoteDebuggerPrefix, cmdData->rfcvalue, (long)epochTime);


github-actions · 2026-05-05T12:57:15Z

Code Coverage Summary

                               Total:|83.5%   5892|97.0%  1531|    -      0

github-actions · 2026-05-05T12:58:16Z

Code Coverage Summary

                               Total:|83.5%   5891|97.0%  1531|    -      0

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Abhinavpv28 added 3 commits April 29, 2026 18:06

Update rrdRunCmdThread.c

314280a

Update rrdRunCmdThread.c

d80af78

Update rrdRunCmdThread.c

39b2e5c

Copilot AI review requested due to automatic review settings May 2, 2026 07:03

Abhinavpv28 requested a review from a team as a code owner May 2, 2026 07:03

Copilot started reviewing on behalf of Abhinavpv28 May 2, 2026 07:03 View session

Copilot started work on behalf of Abhinavpv28 May 2, 2026 07:03 View session

Copilot AI reviewed May 2, 2026

View reviewed changes

Comment thread src/rrdRunCmdThread.c Outdated

Comment thread src/rrdRunCmdThread.c Outdated

Comment thread src/rrdRunCmdThread.c Outdated

Fix format-truncation: increase remoteDebuggerServiceStr buffer to BU…

02ad766

…F_LEN_512 Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/f3e6d001-a244-4693-b073-fad00bcf7bf7 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot finished work on behalf of Abhinavpv28 May 2, 2026 07:12

Delete src/unittest/UTJson/device.properties

b01379f

Copilot AI review requested due to automatic review settings May 4, 2026 16:44

Delete .gitignore

f717399

Copilot started reviewing on behalf of Abhinavpv28 May 4, 2026 16:45 View session

Abhinavpv28 changed the title ~~Feature/rrd append error~~ RDKB-64757 : Remotedebugger debug.txt getting appended while repeatedly query same issueype May 4, 2026

Copilot AI reviewed May 4, 2026

View reviewed changes

Comment thread src/rrdRunCmdThread.c Outdated

Comment thread src/rrdRunCmdThread.c Outdated

AravindanNC approved these changes May 4, 2026

View reviewed changes

AravindanNC requested changes May 4, 2026

View reviewed changes

Update rrdRunCmdThread.c

39991ed

Copilot AI review requested due to automatic review settings May 5, 2026 02:53

Copilot started reviewing on behalf of Abhinavpv28 May 5, 2026 02:54 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread src/rrdRunCmdThread.c

Comment thread src/rrdRunCmdThread.c Outdated

Comment thread src/rrdRunCmdThread.c Outdated

Update L2-tests.yml

d01b8e6

Update rrdRunCmdThread.c

cf98df3

Copilot AI review requested due to automatic review settings May 5, 2026 04:30

Copilot started reviewing on behalf of Abhinavpv28 May 5, 2026 04:30 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Update rrdRunCmdThread.c

2133306

Update L2-tests.yml

be60956

Copilot AI review requested due to automatic review settings May 5, 2026 12:04

Copilot started reviewing on behalf of Abhinavpv28 May 5, 2026 12:05 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Update rrdRunCmdThread.c

a2844ad

Copilot AI review requested due to automatic review settings May 5, 2026 12:55

Copilot started reviewing on behalf of Abhinavpv28 May 5, 2026 12:56 View session

Remove error handling for epoch time retrieval

ff5fda3

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread src/rrdRunCmdThread.c

Comment thread src/rrdRunCmdThread.c

Comment thread src/rrdRunCmdThread.c

Comment thread src/rrdRunCmdThread.c

Conversation

Abhinavpv28 commented May 2, 2026

Uh oh!

Abhinavpv28 commented May 2, 2026

Uh oh!

github-actions Bot commented May 2, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented May 2, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Code Coverage Summary

Uh oh!

github-actions Bot commented May 4, 2026

Code Coverage Summary

Uh oh!

github-actions Bot commented May 4, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

AravindanNC left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 5, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 5, 2026

Code Coverage Summary

Uh oh!

github-actions Bot commented May 5, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 5, 2026

Code Coverage Summary

Uh oh!

github-actions Bot commented May 5, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions Bot commented May 5, 2026

Code Coverage Summary

Uh oh!

github-actions Bot commented May 5, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!