Feature/rdk 60236 structure by Abhinavpv28 · Pull Request #192 · rdkcentral/remote_debugger

Abhinavpv28 · 2026-05-04T15:05:34Z

No description provided.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Abhinavpv28 · 2026-05-04T15:06:10Z

@copilot add gtest testcases for newly aded changes

github-actions · 2026-05-04T15:06:48Z

Code Coverage Summary

                               Total:|83.3%   6022|97.1%  1564|    -      0

Copilot

Pull request overview

This PR introduces support for issue-type “suffixes” (tokens after the first underscore) by splitting issue type strings into a base + persisted suffix, carrying that suffix through data_buf, and using it when building the upload artifact name.

Changes:

Added split_issue_type() utility (exported via rrdJsonParser.h) and comprehensive unit tests for it.
Extended data_buf with a suffix field; initialized/freed it in buffer lifecycle helpers and key processing paths.
Updated issue-type processing to preserve suffix while still using the base issue type for JSON lookup, and adjusted upload naming and sanitization to allow _ and -.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/unittest/rrdUnitTestRunner.cpp	Adds tests for `split_issue_type()` and updates some event/cache tests for new struct fields.
src/rrdJsonParser.h	Exposes the new `split_issue_type()` API.
src/rrdJsonParser.c	Implements `split_issue_type()` and appends persisted suffix into upload tar name; adds cleanup for new `suffix` field.
src/rrdInterface.c	Initializes/frees `data_buf.suffix` in init/dealloc helpers.
src/rrdEventProcess.c	Splits issue types into base/suffix and stores suffix on `data_buf`; expands sanitization to keep `_` and `-`.
src/rrdCommon.h	Extends `data_buf` with `suffix`.

    data_buf rbuf;
    rbuf.mtype = EVENT_MSG;
    rbuf.mdata = strdup("Test");
    rbuf.inDynamic = true;
    rbuf.jsonPath = nullptr;
+    rbuf.suffix = strdup("_search_b675-657-556-656");
    msgRRDHdr msgHdr;


…ypeEvent Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/76cad72a-f67f-4c05-8fb5-bfadf0c173b3 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot · 2026-05-04T15:19:27Z

@copilot add gtest testcases for newly aded changes

Added gtest test cases in commit dcff40f for the newly added functionality:

SplitIssueTypeTest (6 new tests):

NullBaseDoesNotCrash / NullSuffixDoesNotCrash — null pointer guards
ZeroBaseLenDoesNotCrash / ZeroSuffixLenDoesNotCrash — zero-length buffer guards
ExactFitBase — buffer sized exactly for base + NUL
OnlyUnderscoreInput — single _ input

RRDDataBuffInitTest (1 new test):

SuffixInitializedToNull — verifies the new suffix field is set to NULL by RRD_data_buff_init()

RRDDataBuffDeAllocTest (2 new tests):

DeallocateWithSuffixSet — verifies suffix is freed when non-NULL
DeallocateWithAllFieldsNull — all pointer fields NULL doesn't crash

ProcessIssueTypeEvntTest (3 new tests):

IssueTypeWithSuffix_inDynamic_NoJson — issue type with underscore suffix is correctly parsed and handled
IssueTypeStartingWithUnderscore_isSkipped — empty base detection causes the entry to be skipped
MultipleIssueTypesWithAndWithoutSuffix — comma-separated list with mixed types

All 322 tests pass.

github-actions · 2026-05-04T15:57:44Z

Code Coverage Summary

                               Total:|83.7%   6106|97.1%  1612|    -      0

github-actions · 2026-05-05T08:22:42Z

Code Coverage Summary

                               Total:|83.7%   6106|97.1%  1612|    -      0

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

@@ -88,9 +103,19 @@ void processIssueTypeEvent(data_buf *rbuf)
                    }
 		    cmdBuff->appendMode = rbuf->appendMode;


    while (str[source] != '\0')
    {
-        if (isalnum(str[source]) || str[source] == ',' || str[source] == '.')
+        if (isalnum(str[source]) || str[source] == ',' || str[source] == '.' || str[source] == '_'|| str[source] == '-')
        {


Abhinavpv28 added 30 commits April 30, 2026 23:22

Refactor issueTypeSplitter to include suffix handling

cd795e2

Update rrdEventProcess.c

a950f13

Update rrdExecuteScript.c

ba3c8ca

Refactor rrdEventProcess.h to rrdExecuteScript.h

63bc161

Update rrdExecuteScript.h

c883bd2

Update rrdExecuteScript.h

9380442

Update rrdEventProcess.h

61a9e2c

Update rrdExecuteScript.h

d672210

Update rrdJsonParser.c

65d30d0

Update rrdJsonParser.h

93df789

Update rrdInterface.c

6d37d71

Update rrdCommon.h

c7588d3

Update rrdEventProcess.c

d1345ab

Update rrdEventProcess.c

e720479

Update rrdEventProcess.c

faacd2a

Update rrdEventProcess.c

7daeac3

Fix indentation for appendMode assignment

52539a3

Update rrdCommon.h

ec1680e

Fix appendMode assignment in rrdEventProcess.c

bfb7f1e

Update rrdEventProcess.c

e71f82e

Update rrdJsonParser.c

72b9562

Update rrdEventProcess.c

e6b8690

Update rrdExecuteScript.h

79f6e64

Update rrdExecuteScript.c

bd49f43

Update rrdExecuteScript.c

3a5f988

Update rrdExecuteScript.c

4587984

Remove redundant logging from rrdJsonParser

5c3f460

Update rrdJsonParser.c

3d77c29

Update rrdEventProcess.c

b5f062b

Update rrdJsonParser.c

f21ad0f

Abhinavpv28 and others added 14 commits May 3, 2026 12:20

Update rrdEventProcess.c

ca8c14c

Update rrdEventProcess.c

4cb74db

Potential fix for pull request finding

5bf24f2

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Update rrdJsonParser.c

a44c0e8

Update rrdJsonParser.c

3a798ef

Potential fix for pull request finding

c350bb0

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

cf3a830

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

1bc5ed3

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Update rrdUnitTestRunner.cpp

7d1e5ad

Potential fix for pull request finding

f8519e1

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

45e7d46

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Delete .gitignore

9f2018d

Delete src/unittest/UTJson/device.properties

94e5848

Update rrdEventProcess.c

6aaa224

Copilot AI review requested due to automatic review settings May 4, 2026 15:05

Abhinavpv28 requested a review from a team as a code owner May 4, 2026 15:05

Copilot started reviewing on behalf of Abhinavpv28 May 4, 2026 15:06 View session

Copilot started work on behalf of Abhinavpv28 May 4, 2026 15:06 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

Add gtest tests for split_issue_type, suffix field, and processIssueT…

dcff40f

…ypeEvent Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/76cad72a-f67f-4c05-8fb5-bfadf0c173b3 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot finished work on behalf of Abhinavpv28 May 4, 2026 15:20

Delete .gitignore

22f93ba

Copilot AI review requested due to automatic review settings May 5, 2026 08:21

Copilot started reviewing on behalf of Abhinavpv28 May 5, 2026 08:22 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/rdk 60236 structure#192

Feature/rdk 60236 structure#192
Abhinavpv28 wants to merge 78 commits intodevelopfrom
feature/RDK-60236_structure

Abhinavpv28 commented May 4, 2026

Uh oh!

Abhinavpv28 commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -88,9 +103,19 @@ void processIssueTypeEvent(data_buf *rbuf)
		}
		cmdBuff->appendMode = rbuf->appendMode;

Conversation

Abhinavpv28 commented May 4, 2026

Uh oh!

Abhinavpv28 commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Code Coverage Summary

Uh oh!

github-actions Bot commented May 5, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants