Feature/UUID debug.txt by Abhinavpv28 · Pull Request #193 · rdkcentral/remote_debugger

Abhinavpv28 · 2026-05-07T03:44:32Z

No description provided.

…ypeEvent Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/76cad72a-f67f-4c05-8fb5-bfadf0c173b3 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/125526c2-7b70-48f5-8bec-fd725eea8a04 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

…suffix Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/904bf10d-546b-4038-a60c-9bc76094a225 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efdc0d6b-89e6-4423-b202-a900f5683839 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

… built-in special-char removal) Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/00abcaba-8a41-4b88-ae12-07b5ff780ff9 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/4de31e24-70d8-496c-ac6a-a5376771d936 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

…ectly rrd_logproc_convert_issue_type() was converting '-' to '_', turning the suffix '_Search-67768-67' into '_SEARCH_67768_67'. This added extra '_' separators into the archive filename that broke the analytics portal's filename parser — it could no longer identify the timestamp field, so download requests used an incorrect S3 key. Fix: keep '-' as '-' in the sanitized output. The archive filename now uses '_' to separate structural fields (MAC, issueType, timestamp) and '-' within the UUID suffix, giving the portal a reliable delimiter. Also increase issue_type_sanitized buffer in uploadRRDLogs.c from 64 to 256 bytes so a full UUID suffix never causes a silent truncation failure. Before: 04B86A12F9F8_DEVICE_DEVICEIP_SEARCH_67768_67_<timestamp>_RRD_DEBUG_LOGS.tgz After: 04B86A12F9F8_DEVICE_DEVICEIP_SEARCH-67768-67_<timestamp>_RRD_DEBUG_LOGS.tgz All 331 tests pass. Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/981b6bc1-c9d2-4150-9e9d-851004942ffc Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

…9 rule split_issue_type() now discards any suffix whose total length (including the leading '_') exceeds 9 characters. The old _Search-/_LogSearch- prefix validation is removed entirely. Rule: strlen(underscore) <= 9 → suffix accepted strlen(underscore) > 9 → suffix discarded This means: - Short session tokens (e.g. "_ab12345", 8 chars) are carried through - Long UUID-based suffixes like "_Search-b6877385-...) are discarded, preventing extra '_' delimiters from breaking the portal filename parser Affected tests updated: - UnderscoreSplitsBaseAndSuffix : uses a short accepted suffix - MultipleUnderscoresSplitsAtFirst: "_def_ghi" (8 chars) now kept - BaseTruncatedWhenTooSmall / ExactFitBase: "_suffix" (7 chars) now kept - SuffixTruncatedWhenTooSmall: uses 9-char suffix with 5-byte buffer - OnlyUnderscoreInput: "_" (1 char) now kept - LogSearchSuffixIsValid → NineCharSuffixIsAccepted (boundary test) - SearchSuffixIsValid → LongSuffixIsDiscarded - InvalidSuffixPrefixDiscarded / SearchWithoutHyphenIsInvalid / LogSearchWithoutHyphenIsInvalid: updated comments (same outcomes) - ProcessIssueTypeEvntTest comments updated to reflect new rule All 331 tests pass. Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/c6d6fc29-da2a-46af-a417-c2de67a18448 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

…tests - Expand the RRD_MAX_SUFFIX_LEN comment to explain why 9 chars is the limit - Rename misleading test names that referenced old prefix-based validation: InvalidSuffixPrefixDiscarded → SuffixExceedingMaxLengthDiscarded SearchWithoutHyphenIsInvalid → SuffixSeventeenCharsDiscarded LogSearchWithoutHyphenIsInvalid → SuffixTwentyCharsDiscarded - LongSuffixIsDiscarded: switch to a neutral _1234567890 example so the test does not imply any Search-specific behavior All 331 tests pass. Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/c6d6fc29-da2a-46af-a417-c2de67a18448 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

github-actions · 2026-05-07T03:45:53Z

Code Coverage Summary

                               Total:|84.1%   6188|97.3%  1648|    -      0

Abhinavpv28 · 2026-05-07T03:46:09Z

@copilot
instead appending the suffix to filemane, can we append it to RRD_OUTPUT_FILE

Copilot

Pull request overview

This PR adds support for carrying an “issue type suffix” through the remote debugger flow so it can be appended to the upload artifact name, and updates sanitization logic/tests to preserve hyphens (for UUID-like tokens) while also expanding/adjusting unit test coverage.

Changes:

Introduces split_issue_type() and a new data_buf::suffix field, then appends the suffix to the upload issue name in checkIssueNodeInfo().
Updates issue-type tokenization/sanitization flow and adjusts unit tests accordingly (including new tests for splitting behavior and suffix lifecycle).
Preserves hyphens in rrd_logproc_convert_issue_type() and adds a new .gitignore for build/test artifacts.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/uploadRRDLogs.c	Enlarges sanitized issue type buffer to align with archive filename sizing.
src/unittest/rrdUnitTestRunner.cpp	Updates/extends gtest coverage for issue splitting, suffix handling, and sanitization expectations.
src/rrdJsonParser.h	Exposes the new `split_issue_type()` helper.
src/rrdJsonParser.c	Adds `split_issue_type()` and appends `suffix` into the upload issue name; cleans up suffix on error/exit paths.
src/rrdInterface.c	Initializes and frees the newly added `data_buf::suffix`.
src/rrdEventProcess.c	Changes issue token handling to split base/suffix and sanitize base post-split; removes pre-split sanitization.
src/rrdCommon.h	Adds `suffix` field to `data_buf`.
src/rrd_logproc.c	Preserves hyphens during issue type sanitization.
.gitignore	Adds ignore rules for autotools/build artifacts and test outputs.

+/* Maximum allowed suffix length (including the leading '_').
+ * The analytics portal parses archive filenames by splitting on '_'. A suffix
+ * longer than this limit would introduce extra '_' delimiters that shift the
+ * timestamp field to a wrong position, causing download failures.
+ * 9 characters = '_' + up to 8 alphanumeric/short-token chars: long UUID-based
+ * suffixes (e.g. "_Search-b6877385-...") are always > 9 and are therefore
+ * discarded before the archive name is built. */
+#define RRD_MAX_SUFFIX_LEN  9


+void split_issue_type(const char *input, char *base, size_t base_len, char *suffix, size_t suffix_len) 
+{
+    if (base && base_len > 0) 
+	{
+        base[0] = '\0';
+    }
+    if (suffix && suffix_len > 0) 
+	{
+        suffix[0] = '\0';
+    }
+
+    if (!input || !base || !suffix) 
+	{
+        return;
+    }
+
+    if (base_len == 0 || suffix_len == 0) 
+	{


    while (str[source] != '\0')
    {
-        if (isalnum(str[source]) || str[source] == ',' || str[source] == '.')
+        //if (isalnum(str[source]) || str[source] == ',' || str[source] == '.' || str[source] == '_'|| str[source] == '-')
+		if (isalnum(str[source]) || str[source] == ',' || str[source] == '.')
        {


    for (size_t i = 0; input[i] && j < size-1; ++i) {
        char c = input[i];
        if (isalnum((unsigned char)c)) output[j++] = toupper((unsigned char)c);
-        else if (c == '_' || c == '-' || c == '.') output[j++] = '_';
+        else if (c == '_' || c == '.') output[j++] = '_';
+        else if (c == '-') output[j++] = '-'; // preserve hyphens so suffix UUID tokens remain distinct
        // skip other chars


                cmdBuff = (data_buf *)malloc(sizeof(data_buf));
                if (cmdBuff)
                {
-                    dataMsgLen = strlen(cmdMap[index]) + 1;
+                    char base[128] = {0};
+                    char local_suffix[128] = {0};


    int cnt = 1, i = 0;
    char *str = input_str;

-    removeSpecialCharacterfromIssueTypeList(str);
    while (*str == delimeter)
        str++;



…name Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/2420015b-82ba-469b-b752-921aeccf2a63 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot · 2026-05-07T04:07:11Z

@copilot
instead appending the suffix to filemane, can we append it to RRD_OUTPUT_FILE

Done in ce81da8. The suffix is now appended to RRD_OUTPUT_FILE (e.g., debug_outputs_ab12345.txt) instead of the upload archive filename. The issueData struct gained a suffix field, which is propagated from buff->suffix through checkIssueNodeInfo → invokeSanityandCommandExec → executeCommands, where it's inserted before the .txt extension when building finalOutFile. The upload call now uses buff->mdata directly without any suffix.

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.

+ * 9 characters = '_' + up to 8 alphanumeric/short-token chars: long UUID-based
+ * suffixes (e.g. "_Search-b6877385-...") are always > 9 and are therefore
+ * discarded before the archive name is built. */
+#define RRD_MAX_SUFFIX_LEN  50


    while (str[source] != '\0')
    {
-        if (isalnum(str[source]) || str[source] == ',' || str[source] == '.')
+        //if (isalnum(str[source]) || str[source] == ',' || str[source] == '.' || str[source] == '_'|| str[source] == '-')
+		if (isalnum(str[source]) || str[source] == ',' || str[source] == '.')
        {


    int cnt = 1, i = 0;
    char *str = input_str;

-    removeSpecialCharacterfromIssueTypeList(str);
    while (*str == delimeter)
        str++;



    for (size_t i = 0; input[i] && j < size-1; ++i) {
        char c = input[i];
        if (isalnum((unsigned char)c)) output[j++] = toupper((unsigned char)c);
-        else if (c == '_' || c == '-' || c == '.') output[j++] = '_';
+        else if (c == '_' || c == '.') output[j++] = '_';
+        else if (c == '-') output[j++] = '-'; // preserve hyphens so suffix UUID tokens remain distinct
        // skip other chars


+                    }
+                    dataMsgLen = strlen(base) + 1;
                    RRD_data_buff_init(cmdBuff, EVENT_MSG, RRD_DEEPSLEEP_INVALID_DEFAULT); /* Setting Deafult Values*/
                    cmdBuff->inDynamic = rbuf->inDynamic;
                    if(cmdBuff->inDynamic)


Abhinavpv28 added 30 commits April 30, 2026 23:22

Refactor issueTypeSplitter to include suffix handling

cd795e2

Update rrdEventProcess.c

a950f13

Update rrdExecuteScript.c

ba3c8ca

Refactor rrdEventProcess.h to rrdExecuteScript.h

63bc161

Update rrdExecuteScript.h

c883bd2

Update rrdExecuteScript.h

9380442

Update rrdEventProcess.h

61a9e2c

Update rrdExecuteScript.h

d672210

Update rrdJsonParser.c

65d30d0

Update rrdJsonParser.h

93df789

Update rrdInterface.c

6d37d71

Update rrdCommon.h

c7588d3

Update rrdEventProcess.c

d1345ab

Update rrdEventProcess.c

e720479

Update rrdEventProcess.c

faacd2a

Update rrdEventProcess.c

7daeac3

Fix indentation for appendMode assignment

52539a3

Update rrdCommon.h

ec1680e

Fix appendMode assignment in rrdEventProcess.c

bfb7f1e

Update rrdEventProcess.c

e71f82e

Update rrdJsonParser.c

72b9562

Update rrdEventProcess.c

e6b8690

Update rrdExecuteScript.h

79f6e64

Update rrdExecuteScript.c

bd49f43

Update rrdExecuteScript.c

3a5f988

Update rrdExecuteScript.c

4587984

Remove redundant logging from rrdJsonParser

5c3f460

Update rrdJsonParser.c

3d77c29

Update rrdEventProcess.c

b5f062b

Update rrdJsonParser.c

f21ad0f

Abhinavpv28 and others added 16 commits May 4, 2026 20:30

Update rrdEventProcess.c

6aaa224

Add gtest tests for split_issue_type, suffix field, and processIssueT…

dcff40f

…ypeEvent Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/76cad72a-f67f-4c05-8fb5-bfadf0c173b3 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Delete .gitignore

22f93ba

Validate suffix prefix: only _Search- and _LogSearch- are allowed

881aa5f

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/125526c2-7b70-48f5-8bec-fd725eea8a04 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Base never contains underscore: split at first _ and discard invalid …

d031661

…suffix Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/904bf10d-546b-4038-a60c-9bc76094a225 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Update rrdEventProcess.c

9a6b977

Update rrdUnitTestRunner.cpp

815b247

Update rrdEventProcess.c

43a64e1

Update rrdEventProcess.c

31494a7

Fix segfault in GTEST_ENABLE mode when rbuf->jsonPath is NULL

17289c1

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efdc0d6b-89e6-4423-b202-a900f5683839 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Remove accidentally committed dummy directory and update .gitignore

5c8ffb8

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efdc0d6b-89e6-4423-b202-a900f5683839 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Fix empty/whitespace IssueType bypassing processIssueTypeEvent guards

f64d401

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/4de31e24-70d8-496c-ac6a-a5376771d936 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 7, 2026 03:44

Abhinavpv28 requested a review from a team as a code owner May 7, 2026 03:44

Copilot started reviewing on behalf of Abhinavpv28 May 7, 2026 03:45 View session

Copilot started work on behalf of Abhinavpv28 May 7, 2026 03:46 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

refactor: append suffix to RRD_OUTPUT_FILE instead of upload tar file…

ce81da8

…name Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/2420015b-82ba-469b-b752-921aeccf2a63 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot finished work on behalf of Abhinavpv28 May 7, 2026 04:07

Update rrdJsonParser.c

c396224

Copilot AI review requested due to automatic review settings May 7, 2026 06:36

Copilot started reviewing on behalf of Abhinavpv28 May 7, 2026 06:37 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/UUID debug.txt#193

Feature/UUID debug.txt#193
Abhinavpv28 wants to merge 93 commits intodevelopfrom
feature/uuid_debug.txt

Abhinavpv28 commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

Abhinavpv28 commented May 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI commented May 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Abhinavpv28 commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Code Coverage Summary

Uh oh!

Abhinavpv28 commented May 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI commented May 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants