fix(ios): skip simulator fallback for physical device UDIDs - #2829
Open
huytdps13400 wants to merge 1 commit into
Open
fix(ios): skip simulator fallback for physical device UDIDs#2829huytdps13400 wants to merge 1 commit into
huytdps13400 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-ios --udid <physical-device>reachrunOnDevicewithout requiring any installed or matching simulatorFixes #2826
Test Plan
yarn test packages/cli-platform-apple/src/commands/runCommand/__tests__/createRun.test.ts --runInBandfailed before the fix because the mocked simulator lookup threw before the physical-device branch ranyarn test packages/cli-platform-apple/src/commands/runCommand/__tests__/createRun.test.ts --runInBand(5 passed)yarn test packages/cli-platform-apple --runInBand(8 suites, 40 passed)yarn test:ci:unit(55 suites, 314 passed, 1 pre-existing todo)yarn lint(0 errors; 2 pre-existing warnings outside this diff)yarn buildgit diff --checkyarn test:ci:e2eunder Node 22: 3 suites and 21 tests passed; the remaining unrelated fixtures failed because the current config snapshot omits the existingspm [action]command, the local Android fixture has noANDROID_HOME, and Yarn could not register the__e2e__link packageChecklist
--udidphysical-device path without changing CLI options.react-nativecheckout. The device-selection regression is covered directly at thecreateRunboundary instead.