Add back backwards compat for rawProps.at(x,y,z) (#57346)#57346
Closed
javache wants to merge 1 commit into
Closed
Conversation
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109837388. |
meta-cla
Bot
added
the
CLA Signed
cortinico
approved these changes
Jun 26, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: Restores a deprecated three-argument overload of `RawProps::at()` for backwards compatibility with existing callers (like Nitro modules) that pass prefix/suffix separately. The new overload concatenates `prefix + name + suffix` when needed and delegates to the parser's `at(string_view)` method. When both prefix and suffix are null, it forwards directly to the single-argument version. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D109837388
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D109837388
branch
from
8fb1641 to
3407055
Compare
|
This pull request has been merged in ce72288. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Restores a deprecated three-argument overload of
RawProps::at()for backwards compatibility with existing callers (like Nitro modules) that pass prefix/suffix separately.The new overload concatenates
prefix + name + suffixwhen needed and delegates to the parser'sat(string_view)method. When both prefix and suffix are null, it forwards directly to the single-argument version.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D109837388