[CodeQuality] Add WillReturnCallbackFallbackToThrowRector#710
Merged
Conversation
573eecc to
563adae
Compare
… unexpected extra consecutive call
242d59f to
85797b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a rule that turns the unreachable fallback
returnof a consecutivewillReturnCallback()into athrow, so an unexpected extra call fails loudly instead of silently returning a stale value.After
withConsecutive()is migrated to a matcherwillReturnCallback(), the trailingreturnis a leftover of the original singlewillReturn()— it is reached only when the mock is called more often than expected. Returning there hides the over-call; throwing surfaces it.$this->someServiceMock->expects($matcher) ->method('run') ->willReturnCallback(function () use ($matcher) { if ($matcher->numberOfInvocations() === 1) { return 'first'; } if ($matcher->numberOfInvocations() === 2) { return 'second'; } - return 'second'; + throw new \PHPUnit\Framework\Exception(sprintf('Method should not be called for the %dth time', $matcher->numberOfInvocations())); });Only fires when the closure uses
$matcher, branches on its invocation count, and ends with an unconditionalreturn. Added to thephpunit-code-qualityset.