[php 8.4] [type-declaration] Add AddArrayAnyAllClosureParamTypeRector and NarrowArrayAnyAllNullableParamTypeRector#8049
Merged
Conversation
…or and NarrowArrayAnyAllClosureParamTypeRector
48387a4 to
42eb26e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new PHP 8.4 type-declaration rules for
array_any()/array_all()(and friends) closure params.AddArrayAnyAllClosureParamTypeRector
Adds a type to an untyped closure param, based on the array item type.
Handles
array_any(),array_all(). Only fills a param that has no type yet.NarrowArrayAnyAllNullableParamTypeRector
Narrows an already nullable closure param to the non-nullable array item type.
Handles
array_any(),array_all(),array_find(),array_find_key(). Only acts on a?typeparam, and skips when the item type is itself nullable.The two rules are complementary and non-overlapping: one fills a missing type, the other tightens an existing nullable one.