[CodeQuality] Add InitVariableDefaultBeforeNullCoalesceReturnRector#8091
Closed
TomasVotruba wants to merge 1 commit into
Closed
[CodeQuality] Add InitVariableDefaultBeforeNullCoalesceReturnRector#8091TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
…o init variable default instead of null coalesce on return
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
InitVariableDefaultBeforeNullCoalesceReturnRector(CodeQuality).When a variable is only ever filled as an array dimension inside a loop and then returned via
?? <default>to guard the case where the variable was never initialized, this rule moves the default into an explicit init before the first write and drops the null coalesce.function run(array $keys): array { + $result = []; foreach ($keys as $key) { $result[$key] = $key; } - return $result ?? []; + return $result; }Safe gates
Coalesce, left side is a plain variable, right side is a literal default ([],'',0,null, ...)$x = ...) in the scope (else the??guards a real value, skip)$x[...] = ...)